Hi all,
The Tegra EMC scaling support code is not a clock provider, but merely a
clock consumer, and thus does not need to include
<linux/clk-provider.h>.
However, drivers/memory/tegra/tegra210-emc-table.c relies on
tegra210-emc.h to include <linux/of.h> through <linux/clk-provider.h>.
Hence the first patch makes <linux/of_reserved_mem.h> self-contained
first.
Thanks for your comments!
Geert Uytterhoeven (2):
of: Make <linux/of_reserved_mem.h> self-contained
memory: tegra: Drop <linux/clk-provider.h>
drivers/memory/tegra/tegra210-emc-core.c | 1 -
drivers/memory/tegra/tegra210-emc.h | 1 -
include/linux/of_reserved_mem.h | 1 +
3 files changed, 1 insertion(+), 2 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Wed, May 06, 2020 at 02:32:34PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> The Tegra EMC scaling support code is not a clock provider, but merely a
> clock consumer, and thus does not need to include
> <linux/clk-provider.h>.
>
> However, drivers/memory/tegra/tegra210-emc-table.c relies on
> tegra210-emc.h to include <linux/of.h> through <linux/clk-provider.h>.
> Hence the first patch makes <linux/of_reserved_mem.h> self-contained
> first.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (2):
> of: Make <linux/of_reserved_mem.h> self-contained
> memory: tegra: Drop <linux/clk-provider.h>
>
> drivers/memory/tegra/tegra210-emc-core.c | 1 -
> drivers/memory/tegra/tegra210-emc.h | 1 -
> include/linux/of_reserved_mem.h | 1 +
> 3 files changed, 1 insertion(+), 2 deletions(-)
Ah... I should've read the cover letter first. Looks like I need to take
that first patch through the Tegra tree as well to avoid introducing the
build error in the second patch.
Rob, do you mind if I pick up patch 1 of this into the same OF branch
that I already carry the memory-region-names patches on?
Thierry
On Thu, May 07, 2020 at 10:07:18PM +0200, Thierry Reding wrote:
> On Wed, May 06, 2020 at 02:32:34PM +0200, Geert Uytterhoeven wrote:
> > Hi all,
> >
> > The Tegra EMC scaling support code is not a clock provider, but merely a
> > clock consumer, and thus does not need to include
> > <linux/clk-provider.h>.
> >
> > However, drivers/memory/tegra/tegra210-emc-table.c relies on
> > tegra210-emc.h to include <linux/of.h> through <linux/clk-provider.h>.
> > Hence the first patch makes <linux/of_reserved_mem.h> self-contained
> > first.
> >
> > Thanks for your comments!
> >
> > Geert Uytterhoeven (2):
> > of: Make <linux/of_reserved_mem.h> self-contained
> > memory: tegra: Drop <linux/clk-provider.h>
> >
> > drivers/memory/tegra/tegra210-emc-core.c | 1 -
> > drivers/memory/tegra/tegra210-emc.h | 1 -
> > include/linux/of_reserved_mem.h | 1 +
> > 3 files changed, 1 insertion(+), 2 deletions(-)
>
> Ah... I should've read the cover letter first. Looks like I need to take
> that first patch through the Tegra tree as well to avoid introducing the
> build error in the second patch.
>
> Rob, do you mind if I pick up patch 1 of this into the same OF branch
> that I already carry the memory-region-names patches on?
No, it's fine.
Acked-by: Rob Herring <[email protected]>