2020-05-06 13:46:24

by Jason Yan

[permalink] [raw]
Subject: [PATCH] MIPS: Lasat: Remove dead code in lasat.h

This code has been marked dead for more than 10 years. Seems no need to
keep it now.

Signed-off-by: Jason Yan <[email protected]>
---
arch/mips/include/asm/lasat/lasat.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/mips/include/asm/lasat/lasat.h b/arch/mips/include/asm/lasat/lasat.h
index 483be606960d..7659818f6553 100644
--- a/arch/mips/include/asm/lasat/lasat.h
+++ b/arch/mips/include/asm/lasat/lasat.h
@@ -121,11 +121,6 @@ struct lasat_eeprom_struct_pre7 {
#define LASAT_BMID_SAFEPIPE5000 5
#define LASAT_BMID_SAFEPIPE7000 6
#define LASAT_BMID_SAFEPIPE1000 7
-#if 0
-#define LASAT_BMID_SAFEPIPE30 7
-#define LASAT_BMID_SAFEPIPE5100 8
-#define LASAT_BMID_SAFEPIPE7100 9
-#endif
#define LASAT_BMID_UNKNOWN 0xf
#define LASAT_MAX_BMID_NAMES 9 /* no larger than 15! */

--
2.21.1


2020-05-07 08:44:15

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Lasat: Remove dead code in lasat.h

On Wed, May 06, 2020 at 09:42:58PM +0800, Jason Yan wrote:
> This code has been marked dead for more than 10 years. Seems no need to
> keep it now.
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> arch/mips/include/asm/lasat/lasat.h | 5 -----
> 1 file changed, 5 deletions(-)

I'll send a patch shortly to remove lasat completly. Therefore I'm
not going to apply this cleanup patch.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

2020-05-07 09:00:06

by Jason Yan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Lasat: Remove dead code in lasat.h



?? 2020/5/7 16:38, Thomas Bogendoerfer ะด??:
> On Wed, May 06, 2020 at 09:42:58PM +0800, Jason Yan wrote:
>> This code has been marked dead for more than 10 years. Seems no need to
>> keep it now.
>>
>> Signed-off-by: Jason Yan <[email protected]>
>> ---
>> arch/mips/include/asm/lasat/lasat.h | 5 -----
>> 1 file changed, 5 deletions(-)
>
> I'll send a patch shortly to remove lasat completly. Therefore I'm
> not going to apply this cleanup patch.
>

OK, thanks for letting me know this infomation.

Jason

> Thomas.
>