Add device tree compatible string for tps6598x driver and create the dt binding doc for the driver
Angus Ainslie (2):
usb: typec: tps6598x: add device tree hooks
dt-bindings: usb: ti,tps6598x: add dt binding doc
.../devicetree/bindings/usb/ti,tps6598x.yaml | 75 +++++++++++++++++++
drivers/usb/typec/tps6598x.c | 7 ++
2 files changed, 82 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
--
2.25.1
Document the tps6598x driver
Signed-off-by: Angus Ainslie <[email protected]>
---
.../devicetree/bindings/usb/ti,tps6598x.yaml | 75 +++++++++++++++++++
1 file changed, 75 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
new file mode 100644
index 000000000000..925db38aaf84
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ti,tps6598x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI tps6598x driver
+
+maintainers:
+ -
+
+properties:
+ $nodename:
+ pattern: '^usb-pd@.*'
+
+ compatible:
+ oneOf:
+ - enum:
+ - ti,tps6598x
+ - items:
+ - const: ti,tps6598x
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ connector:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ typec_pd: usb-pd@3f {
+ compatible = "ti,tps6598x";
+ reg = <0x3f>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_typec>, <&pinctrl_tcpc>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
+
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb_con_hs: endpoint {
+ remote-endpoint = <&typec_hs>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ usb_con_ss: endpoint {
+ remote-endpoint = <&typec_ss>;
+ };
+ };
+ };
+ };
+ };
--
2.25.1
On Wed, 6 May 2020 12:17:18 -0700, Angus Ainslie wrote:
> Document the tps6598x driver
>
> Signed-off-by: Angus Ainslie <[email protected]>
> ---
> .../devicetree/bindings/usb/ti,tps6598x.yaml | 75 +++++++++++++++++++
> 1 file changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: maintainers:0: None is not of type 'string'
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: ignoring, error in schema: maintainers: 0
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml: ignoring, error in schema: maintainers: 0
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1284704
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
Hi Rob,
On 2020-05-11 08:26, Rob Herring wrote:
> On Wed, 6 May 2020 12:17:18 -0700, Angus Ainslie wrote:
>> Document the tps6598x driver
>>
>> Signed-off-by: Angus Ainslie <[email protected]>
>> ---
>> .../devicetree/bindings/usb/ti,tps6598x.yaml | 75
>> +++++++++++++++++++
>> 1 file changed, 75 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> maintainers:0: None is not of type 'string'
> Documentation/devicetree/bindings/Makefile:12: recipe for target
> 'Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts' failed
> make[1]: ***
> [Documentation/devicetree/bindings/usb/ti,tps6598x.example.dts] Error
> 1
> make[1]: *** Waiting for unfinished jobs....
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> ignoring, error in schema: maintainers: 0
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml:
> ignoring, error in schema: maintainers: 0
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> Makefile:1300: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1284704
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install
> git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.
I think the consesus was to use this one instead.
https://lore.kernel.org/lkml/[email protected]/
Thanks
Angus