2020-05-07 07:14:03

by Xu Wang

Subject: [PATCH] drivers: block: use set_current_state macro

Use set_current_state macro instead of current->state = TASK_RUNNING.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/block/swim.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index 4c297f69171d..dd34504382e5 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -327,7 +327,7 @@ static inline void swim_motor(struct swim __iomem *base,
swim_select(base, RELAX);
if (swim_readbit(base, MOTOR_ON))
break;
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
} else if (action == OFF) {
@@ -346,7 +346,7 @@ static inline void swim_eject(struct swim __iomem *base)
swim_select(base, RELAX);
if (!swim_readbit(base, DISK_IN))
break;
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
swim_select(base, RELAX);
@@ -370,7 +370,7 @@ static inline int swim_step(struct swim __iomem *base)

for (wait = 0; wait < HZ; wait++) {

- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);

swim_select(base, RELAX);
--
2.17.1

2020-05-16 04:30:36

by Chaitanya Kulkarni

Subject: Re: [PATCH] drivers: block: use set_current_state macro

On 05/07/2020 12:20 AM, Xu Wang wrote:
> Use set_current_state macro instead of current->state = TASK_RUNNING.
>
> Signed-off-by: Xu Wang<[email protected]>

Reviewed-by: Chaitanya Kulkarni <[email protected]>

2020-05-16 20:31:28

by Jens Axboe

Subject: Re: [PATCH] drivers: block: use set_current_state macro

On 5/7/20 1:12 AM, Xu Wang wrote:
> Use set_current_state macro instead of current->state = TASK_RUNNING.

Applied, thanks.

--
Jens Axboe