2020-05-07 08:01:19

by Zheng Zengkai

Subject: [PATCH net-next] net: phy: Make iproc_mdio_resume static

Fix sparse warnings:

drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
symbol 'iproc_mdio_resume' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zheng Zengkai <[email protected]>
---
drivers/net/phy/mdio-bcm-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c
index f1ded03f0229..89bdfcc0e506 100644
--- a/drivers/net/phy/mdio-bcm-iproc.c
+++ b/drivers/net/phy/mdio-bcm-iproc.c
@@ -179,7 +179,7 @@ static int iproc_mdio_remove(struct platform_device *pdev)
}

#ifdef CONFIG_PM_SLEEP
-int iproc_mdio_resume(struct device *dev)
+static int iproc_mdio_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct iproc_mdio_priv *priv = platform_get_drvdata(pdev);
--
2.20.1

2020-05-07 15:45:39

by Florian Fainelli

Subject: Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static

On 5/7/2020 1:03 AM, Zheng Zengkai wrote:
> Fix sparse warnings:
>
> drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
> symbol 'iproc_mdio_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zheng Zengkai <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-05-07 19:59:11

by David Miller

Subject: Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static

From: Zheng Zengkai <[email protected]>
Date: Thu, 7 May 2020 16:03:26 +0800

> Fix sparse warnings:
>
> drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
> symbol 'iproc_mdio_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zheng Zengkai <[email protected]>

Applied.