2020-05-07 00:42:09

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the vfs tree

---

Hi all,

After merging the vfs tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

fs/eventfd.c: In function 'eventfd_read':
fs/eventfd.c:226:6: error: implicit declaration of function 'iov_iter_count' [-Werror=implicit-function-declaration]
226 | if (iov_iter_count(to) < sizeof(ucnt))
| ^~~~~~~~~~~~~~
In file included from include/linux/file.h:9,
from fs/eventfd.c:9:
fs/eventfd.c:257:15: error: implicit declaration of function 'copy_to_iter'; did you mean 'copy_to_user'? [-Werror=implicit-function-declaration]
257 | if (unlikely(copy_to_iter(&ucnt, sizeof(ucnt), to) != sizeof(ucnt)))
| ^~~~~~~~~~~~

Caused by commit

a6515b3a7410 ("eventfd: convert to f_op->read_iter()")

I have applied the following patch for today:

From: Stephen Rothwell <[email protected]>
Date: Thu, 7 May 2020 10:35:52 +1000
Subject: [PATCH] eventfd: include uio.h

Fixes: a6515b3a7410 ("eventfd: convert to f_op->read_iter()")
Signed-off-by: Stephen Rothwell <[email protected]>
---
fs/eventfd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/eventfd.c b/fs/eventfd.c
index 20f0fd4d56e1..df466ef81ddd 100644
--- a/fs/eventfd.c
+++ b/fs/eventfd.c
@@ -23,6 +23,7 @@
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/idr.h>
+#include <linux/uio.h>

DEFINE_PER_CPU(int, eventfd_wake_count);

--
2.26.2

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2020-05-07 03:26:01

by Al Viro

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the vfs tree

---

On Thu, May 07, 2020 at 10:39:21AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the vfs tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> fs/eventfd.c: In function 'eventfd_read':
> fs/eventfd.c:226:6: error: implicit declaration of function 'iov_iter_count' [-Werror=implicit-function-declaration]
> 226 | if (iov_iter_count(to) < sizeof(ucnt))
> | ^~~~~~~~~~~~~~
> In file included from include/linux/file.h:9,
> from fs/eventfd.c:9:
> fs/eventfd.c:257:15: error: implicit declaration of function 'copy_to_iter'; did you mean 'copy_to_user'? [-Werror=implicit-function-declaration]
> 257 | if (unlikely(copy_to_iter(&ucnt, sizeof(ucnt), to) != sizeof(ucnt)))
> | ^~~~~~~~~~~~
>
> Caused by commit
>
> a6515b3a7410 ("eventfd: convert to f_op->read_iter()")
>
> I have applied the following patch for today:

[snip]

folded and pushed out

2020-05-07 15:09:24

by Jens Axboe

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the vfs tree

---

On 5/6/20 8:35 PM, Al Viro wrote:
> On Thu, May 07, 2020 at 10:39:21AM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the vfs tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> fs/eventfd.c: In function 'eventfd_read':
>> fs/eventfd.c:226:6: error: implicit declaration of function 'iov_iter_count' [-Werror=implicit-function-declaration]
>> 226 | if (iov_iter_count(to) < sizeof(ucnt))
>> | ^~~~~~~~~~~~~~
>> In file included from include/linux/file.h:9,
>> from fs/eventfd.c:9:
>> fs/eventfd.c:257:15: error: implicit declaration of function 'copy_to_iter'; did you mean 'copy_to_user'? [-Werror=implicit-function-declaration]
>> 257 | if (unlikely(copy_to_iter(&ucnt, sizeof(ucnt), to) != sizeof(ucnt)))
>> | ^~~~~~~~~~~~
>>
>> Caused by commit
>>
>> a6515b3a7410 ("eventfd: convert to f_op->read_iter()")
>>
>> I have applied the following patch for today:
>
> [snip]
>
> folded and pushed out

Thanks Al.

--
Jens Axboe