2020-05-07 11:09:46

by Jason Yan

Subject: [PATCH] ata: return true in ata_is_host_link()

Fix the following coccicheck warning:

include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function
'ata_is_host_link' with return type bool

Signed-off-by: Jason Yan <[email protected]>
---
include/linux/libata.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/libata.h b/include/linux/libata.h
index 8bf5e59a7859..e05a8ed2e31e 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1443,7 +1443,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap)

static inline bool ata_is_host_link(const struct ata_link *link)
{
- return 1;
+ return true;
}
#endif /* CONFIG_SATA_PMP */

--
2.21.1

2020-06-01 13:36:39

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] ata: return true in ata_is_host_link()

On 5/7/20 1:06 PM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function
> 'ata_is_host_link' with return type bool
>
> Signed-off-by: Jason Yan <[email protected]>

Acked-by: Bartlomiej Zolnierkiewicz <[email protected]>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> include/linux/libata.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 8bf5e59a7859..e05a8ed2e31e 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -1443,7 +1443,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap)
>
> static inline bool ata_is_host_link(const struct ata_link *link)
> {
> - return 1;
> + return true;
> }
> #endif /* CONFIG_SATA_PMP */
>