2020-05-07 11:11:50

by Jason Yan

[permalink] [raw]
Subject: [PATCH net-next] net: atheros: remove dead code in atl1c_resume()

This code has been marked dead for nearly 10 years. Remove it.

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 04bc53af12d9..decab9a8e4a8 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -2449,12 +2449,6 @@ static int atl1c_resume(struct device *dev)
atl1c_reset_mac(&adapter->hw);
atl1c_phy_init(&adapter->hw);

-#if 0
- AT_READ_REG(&adapter->hw, REG_PM_CTRLSTAT, &pm_data);
- pm_data &= ~PM_CTRLSTAT_PME_EN;
- AT_WRITE_REG(&adapter->hw, REG_PM_CTRLSTAT, pm_data);
-#endif
-
netif_device_attach(netdev);
if (netif_running(netdev))
atl1c_up(adapter);
--
2.21.1


2020-05-07 20:06:28

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next] net: atheros: remove dead code in atl1c_resume()

From: Jason Yan <[email protected]>
Date: Thu, 7 May 2020 19:08:36 +0800

> This code has been marked dead for nearly 10 years. Remove it.
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.