2020-05-09 06:33:42

by Jason Yan

[permalink] [raw]
Subject: [PATCH] drm/amd/amdgpu: remove defined but not used 'crtc_offsets'

Fix the following gcc warning:

drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:65:18: warning: ‘crtc_offsets’
defined but not used [-Wunused-const-variable=]
static const u32 crtc_offsets[6] =
^~~~~~~~~~~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index c1a530dbe162..a75e472b4a81 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
@@ -61,17 +61,6 @@ MODULE_FIRMWARE("amdgpu/si58_mc.bin");
#define MC_SEQ_MISC0__MT__HBM 0x60000000
#define MC_SEQ_MISC0__MT__DDR3 0xB0000000

-
-static const u32 crtc_offsets[6] =
-{
- SI_CRTC0_REGISTER_OFFSET,
- SI_CRTC1_REGISTER_OFFSET,
- SI_CRTC2_REGISTER_OFFSET,
- SI_CRTC3_REGISTER_OFFSET,
- SI_CRTC4_REGISTER_OFFSET,
- SI_CRTC5_REGISTER_OFFSET
-};
-
static void gmc_v6_0_mc_stop(struct amdgpu_device *adev)
{
u32 blackout;
--
2.21.1


2020-05-11 21:42:16

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/amdgpu: remove defined but not used 'crtc_offsets'

Applied. thanks!

Alex

On Sat, May 9, 2020 at 5:05 AM Jason Yan <[email protected]> wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:65:18: warning: ‘crtc_offsets’
> defined but not used [-Wunused-const-variable=]
> static const u32 crtc_offsets[6] =
> ^~~~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index c1a530dbe162..a75e472b4a81 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -61,17 +61,6 @@ MODULE_FIRMWARE("amdgpu/si58_mc.bin");
> #define MC_SEQ_MISC0__MT__HBM 0x60000000
> #define MC_SEQ_MISC0__MT__DDR3 0xB0000000
>
> -
> -static const u32 crtc_offsets[6] =
> -{
> - SI_CRTC0_REGISTER_OFFSET,
> - SI_CRTC1_REGISTER_OFFSET,
> - SI_CRTC2_REGISTER_OFFSET,
> - SI_CRTC3_REGISTER_OFFSET,
> - SI_CRTC4_REGISTER_OFFSET,
> - SI_CRTC5_REGISTER_OFFSET
> -};
> -
> static void gmc_v6_0_mc_stop(struct amdgpu_device *adev)
> {
> u32 blackout;
> --
> 2.21.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel