2020-05-09 02:45:19

by Hongbo Yao

[permalink] [raw]

Subject: [PATCH -next] power: reset: ltc2952: remove set but used variable

---

Fixes gcc '-Wunused-but-set-variable' warning:
drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
‘overruns’ set but not used [-Wunused-but-set-variable]
unsigned long overruns;

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Hongbo Yao <[email protected]>
---
drivers/power/reset/ltc2952-poweroff.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
index e4a0cc45b3d1..318927938b05 100644
--- a/drivers/power/reset/ltc2952-poweroff.c
+++ b/drivers/power/reset/ltc2952-poweroff.c
@@ -94,7 +94,6 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
{
ktime_t now;
int state;
- unsigned long overruns;
struct ltc2952_poweroff *data = to_ltc2952(timer, timer_wde);

if (data->kernel_panic)
@@ -104,7 +103,7 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
gpiod_set_value(data->gpio_watchdog, !state);

now = hrtimer_cb_get_time(timer);
- overruns = hrtimer_forward(timer, now, data->wde_interval);
+ hrtimer_forward(timer, now, data->wde_interval);

return HRTIMER_RESTART;
}
--
2.20.1

2020-05-09 23:45:08

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH -next] power: reset: ltc2952: remove set but used variable

---

Hi,

On Sat, May 09, 2020 at 06:36:11PM +0800, Hongbo Yao wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]
> unsigned long overruns;
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Hongbo Yao <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/reset/ltc2952-poweroff.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
> index e4a0cc45b3d1..318927938b05 100644
> --- a/drivers/power/reset/ltc2952-poweroff.c
> +++ b/drivers/power/reset/ltc2952-poweroff.c
> @@ -94,7 +94,6 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
> {
> ktime_t now;
> int state;
> - unsigned long overruns;
> struct ltc2952_poweroff *data = to_ltc2952(timer, timer_wde);
>
> if (data->kernel_panic)
> @@ -104,7 +103,7 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
> gpiod_set_value(data->gpio_watchdog, !state);
>
> now = hrtimer_cb_get_time(timer);
> - overruns = hrtimer_forward(timer, now, data->wde_interval);
> + hrtimer_forward(timer, now, data->wde_interval);
>
> return HRTIMER_RESTART;
> }
> --
> 2.20.1
>

---

Attachments:

(No filename) (1.38 kB)
signature.asc (849.00 B)
Download all attachments