Coding style issue
Signed-off-by: John Oldman <[email protected]>
---
v1: Initial attempt.
V2: Resubmitted with shorter comment line, as suggested by Greg KH.
This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
.../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index 1640906e3929..993535bbc479 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -15,10 +15,10 @@ static int g_once_init;
static struct mutex g_connected_mutex;
/****************************************************************************
-*
-* Function to initialize our lock.
-*
-***************************************************************************/
+ *
+ * Function to initialize our lock.
+ *
+ ***************************************************************************/
static void connected_init(void)
{
@@ -29,13 +29,13 @@ static void connected_init(void)
}
/****************************************************************************
-*
-* This function is used to defer initialization until the vchiq stack is
-* initialized. If the stack is already initialized, then the callback will
-* be made immediately, otherwise it will be deferred until
-* vchiq_call_connected_callbacks is called.
-*
-***************************************************************************/
+ *
+ * This function is used to defer initialization until the vchiq stack is
+ * initialized. If the stack is already initialized, then the callback will
+ * be made immediately, otherwise it will be deferred until
+ * vchiq_call_connected_callbacks is called.
+ *
+ ***************************************************************************/
void vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
{
@@ -64,11 +64,11 @@ void vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
}
/****************************************************************************
-*
-* This function is called by the vchiq stack once it has been connected to
-* the videocore and clients can start to use the stack.
-*
-***************************************************************************/
+ *
+ * This function is called by the vchiq stack once it has been connected to
+ * the videocore and clients can start to use the stack.
+ *
+ ***************************************************************************/
void vchiq_call_connected_callbacks(void)
{
--
2.17.1
On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote:
> Coding style issue
>
> Signed-off-by: John Oldman <[email protected]>
> ---
> v1: Initial attempt.
> V2: Resubmitted with shorter comment line, as suggested by Greg KH.
>
> This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
Why is this text not in the changelog area? Don't you think that it is
better than the 3 words you currently put there?
Please fix up and resend.
thanks,
greg k-h
Thanks for the feedback Greg.
Will resubmit the patch as you suggest.
Thanks
john
On Sun, 10 May 2020 at 07:55, Greg KH <[email protected]> wrote:
>
> On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote:
> > Coding style issue
> >
> > Signed-off-by: John Oldman <[email protected]>
> > ---
> > v1: Initial attempt.
> > V2: Resubmitted with shorter comment line, as suggested by Greg KH.
> >
> > This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
>
> Why is this text not in the changelog area? Don't you think that it is
> better than the 3 words you currently put there?
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h