2020-05-12 02:39:19

by Zou Wei

Subject: [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static

Fix the following sparse warning:

arch/arm/mach-omap2/pm33xx-core.c:270:14: warning: symbol 'am43xx_get_rtc_base_addr' was not declared.

The am43xx_get_rtc_base_addr has only call site within pm33xx-core.c
It should be static

Fixes: 8c5a916f4c88 ("ARM: OMAP2+: sleep33/43xx: Add RTC-Mode support")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
arch/arm/mach-omap2/pm33xx-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index 5455fc9..58236c7 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -267,7 +267,7 @@ static struct am33xx_pm_sram_addr *amx3_get_sram_addrs(void)
return NULL;
}

-void __iomem *am43xx_get_rtc_base_addr(void)
+static void __iomem *am43xx_get_rtc_base_addr(void)
{
rtc_oh = omap_hwmod_lookup("rtc");

--
2.6.2

2020-05-12 15:44:06

by Tony Lindgren

Subject: Re: [PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static

* Samuel Zou <[email protected]> [200511 19:36]:
> Fix the following sparse warning:
>
> arch/arm/mach-omap2/pm33xx-core.c:270:14: warning: symbol 'am43xx_get_rtc_base_addr' was not declared.
>
> The am43xx_get_rtc_base_addr has only call site within pm33xx-core.c
> It should be static
>
> Fixes: 8c5a916f4c88 ("ARM: OMAP2+: sleep33/43xx: Add RTC-Mode support")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Applying into omap-for-v5.8/soc thanks.

Tony