2020-05-12 18:20:33

by Anders Roxell

Subject: [PATCH v2] scripts: fix deprecated always and hostprogs-y

When I did an allmodconfig build the following warning showed up:

scripts/Makefile.lib:8: 'always' is deprecated. Please use 'always-y' instead
scripts/Makefile.lib:12: 'hostprogs-y' and 'hostprogs-m' are deprecated. Please use 'hostprogs' instead

Rework to use the new 'always-y' and 'hostprogs'.

Fixes: 631ec151fd96 ("Add sample notification program")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Anders Roxell <[email protected]>
---

Fixed Masahiro's comments.

samples/watch_queue/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/watch_queue/Makefile b/samples/watch_queue/Makefile
index eec00dd0a8df..8511fb6c53d2 100644
--- a/samples/watch_queue/Makefile
+++ b/samples/watch_queue/Makefile
@@ -1,7 +1,7 @@
# List of programs to build
-hostprogs-y := watch_test
+hostprogs := watch_test

# Tell kbuild to always build the programs
-always := $(hostprogs-y)
+always-y := $(hostprogs)

HOSTCFLAGS_watch_test.o += -I$(objtree)/usr/include
--
2.20.1

2020-05-19 16:22:49

by David Howells

Subject: Re: [PATCH v2] scripts: fix deprecated always and hostprogs-y

Anders Roxell <[email protected]> wrote:

> When I did an allmodconfig build the following warning showed up:
>
> scripts/Makefile.lib:8: 'always' is deprecated. Please use 'always-y' instead
> scripts/Makefile.lib:12: 'hostprogs-y' and 'hostprogs-m' are deprecated. Please use 'hostprogs' instead
>
> Rework to use the new 'always-y' and 'hostprogs'.
>
> Fixes: 631ec151fd96 ("Add sample notification program")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Anders Roxell <[email protected]>

I've folded this in, thanks.

David