2020-05-09 01:59:24

by Qian Cai

Subject: [PATCH -next] iommu/amd: fix variable "iommu" set but not used

The commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device()
call-backs") introduced an unused variable,

drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device':
drivers/iommu/amd_iommu.c:422:20: warning: variable 'iommu' set but not
used [-Wunused-but-set-variable]
struct amd_iommu *iommu;
^~~~~

Signed-off-by: Qian Cai <[email protected]>
---
drivers/iommu/amd_iommu.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index fef3689ee535..2b8eb58d2bea 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -419,15 +419,12 @@ static void iommu_ignore_device(struct device *dev)
static void amd_iommu_uninit_device(struct device *dev)
{
struct iommu_dev_data *dev_data;
- struct amd_iommu *iommu;
int devid;

devid = get_device_id(dev);
if (devid < 0)
return;

- iommu = amd_iommu_rlookup_table[devid];
-
dev_data = search_dev_data(devid);
if (!dev_data)
return;
--
2.21.0 (Apple Git-122.2)

2020-05-13 08:44:53

by Joerg Roedel

Subject: Re: [PATCH -next] iommu/amd: fix variable "iommu" set but not used

On Fri, May 08, 2020 at 09:56:45PM -0400, Qian Cai wrote:
> The commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device()
> call-backs") introduced an unused variable,
>
> drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device':
> drivers/iommu/amd_iommu.c:422:20: warning: variable 'iommu' set but not
> used [-Wunused-but-set-variable]
> struct amd_iommu *iommu;
> ^~~~~
>
> Signed-off-by: Qian Cai <[email protected]>
> ---
> drivers/iommu/amd_iommu.c | 3 ---
> 1 file changed, 3 deletions(-)

Applied, thanks.