2020-05-13 16:04:34

by Andy Lutomirski

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] mm: Get rid of vmalloc_sync_(un)mappings()

On Wed, May 13, 2020 at 8:21 AM Joerg Roedel <[email protected]> wrote:
>
> Hi,
>
> here is the next post of this series with these changes to the first
> version:
>
> - Rebased to v5.7-rc5
>
> - As a result of the rebase, also removed the
> vmalloc_sync_mappings() call from tracing code
>
> - Added a comment that we rely on the compiler optimizing calls
> to arch_syn_kernel_mappings() away when
> ARCH_PAGE_TABLE_SYNC_MASK is 0
>
> The first version can be found here:
>
> https://lore.kernel.org/lkml/[email protected]/
>
> The cover letter of the first post also has more details on the
> motivation for this patch-set.
>
> Please review.
>

Assuming the missing cleanup at the end gets done:

Acked-by: Andy Lutomirski <[email protected]>

grumpily acked, anyway.

I would love to see a followup patch that preallocates the vmalloc
region on 64-bit and compiles out pgd_list and all of the associated
gunk.


2020-05-14 14:51:53

by Joerg Roedel

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] mm: Get rid of vmalloc_sync_(un)mappings()

On Wed, May 13, 2020 at 09:01:04AM -0700, Andy Lutomirski wrote:
> Assuming the missing cleanup at the end gets done:
>
> Acked-by: Andy Lutomirski <[email protected]>
>
> grumpily acked, anyway.

Thanks, I updated patch 7 and added your acks, will send a v3 probably
tomorrow.


Joerg

2020-05-15 13:06:56

by Jörg Rödel

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] mm: Get rid of vmalloc_sync_(un)mappings()

On Wed, May 13, 2020 at 09:01:04AM -0700, Andy Lutomirski wrote:
> I would love to see a followup patch that preallocates the vmalloc
> region on 64-bit and compiles out pgd_list and all of the associated
> gunk.

Looked a bit into this, with pre-allocation and a few more changes all
but one users of pgd_list and pgd_lock can be get rid of on x86-64. But
there is the XEN-PV code which also needs to traverse pgd_list, and I am
not sure how to get rid of that.

Regards,

Joerg