2020-05-16 00:42:02

by Ben Boeckel

Subject: [PATCH 1/1] Documentation: security: core.rst: add missing argument

From: Ben Boeckel <[email protected]>

This argument was just never documented in the first place.

Signed-off-by: Ben Boeckel <[email protected]>
---
Documentation/security/keys/core.rst | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/security/keys/core.rst b/Documentation/security/keys/core.rst
index d9b0b859018b..c26b9e7d47c2 100644
--- a/Documentation/security/keys/core.rst
+++ b/Documentation/security/keys/core.rst
@@ -920,10 +920,14 @@ The keyctl syscall functions are:

long keyctl(KEYCTL_PKEY_QUERY,
key_serial_t key_id, unsigned long reserved,
+ const char* params,
struct keyctl_pkey_query *info);

- Get information about an asymmetric key. The information is returned in
- the keyctl_pkey_query struct::
+ Get information about an asymmetric key. Specific algorithms and
+ encodings may be queried by using the ``params`` argument. This is a
+ string containing a space- or tab-separated string of key-value pairs.
+ Currently supported keys include ``enc`` and ``hash``. The information
+ is returned in the keyctl_pkey_query struct::

__u32 supported_ops;
__u32 key_size;
--
2.25.4

2020-05-16 21:21:28

by Jarkko Sakkinen

Subject: Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

On Fri, 2020-05-15 at 20:39 -0400, Ben Boeckel wrote:
> From: Ben Boeckel <[email protected]>
>
> This argument was just never documented in the first place.
>
> Signed-off-by: Ben Boeckel <[email protected]>

Reviewed-by: Jarkko Sakkinen <[email protected]>

/Jarkko

2020-05-18 14:13:44

by David Howells

Subject: Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

Ben Boeckel <[email protected]> wrote:

> long keyctl(KEYCTL_PKEY_QUERY,
> key_serial_t key_id, unsigned long reserved,
> + const char* params,
> struct keyctl_pkey_query *info);

"const char *params". I fixed that and applied it.

David

2020-05-25 21:08:56

by Jonathan Corbet

Subject: Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

On Fri, 15 May 2020 20:39:17 -0400
Ben Boeckel <[email protected]> wrote:

> From: Ben Boeckel <[email protected]>
>
> This argument was just never documented in the first place.
>
> Signed-off-by: Ben Boeckel <[email protected]>
> ---
> Documentation/security/keys/core.rst | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks.

jon

2020-05-25 22:18:38

by Jonathan Corbet

Subject: Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

On Mon, 25 May 2020 10:33:10 -0600
Jonathan Corbet <[email protected]> wrote:

> On Fri, 15 May 2020 20:39:17 -0400
> Ben Boeckel <[email protected]> wrote:
>
> > From: Ben Boeckel <[email protected]>
> >
> > This argument was just never documented in the first place.
> >
> > Signed-off-by: Ben Boeckel <[email protected]>
> > ---
> > Documentation/security/keys/core.rst | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
>
> Applied, thanks.

...or not...looks like David got there first. Sorry for the noise.

jon

2020-05-26 16:09:25

by David Howells

Subject: Re: [PATCH 1/1] Documentation: security: core.rst: add missing argument

Jonathan Corbet <[email protected]> wrote:

> Applied, thanks.

Ah - I've applied it to my keys-next branch.

David