The patch set adds system PMU support for i.MX8 DDR Perf.
The sysfs location for userspace to get the PMU identifier under the
directory:
/sys/bus/event_source/devices/<PMU DEVICE>/identifier
Joakim Zhang (3):
perf/imx_ddr: Add system PMU identifier for userspace
bindings/perf/imx-ddr: update compatible string
arch: arm64: imx8mq/m/n: remove unused compatible string
.../devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +-
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
drivers/perf/fsl_imx8_ddr_perf.c | 45 +++++++++++++++++--
5 files changed, 48 insertions(+), 7 deletions(-)
--
2.17.1
Update compatible string according to driver change.`
Signed-off-by: Joakim Zhang <[email protected]>
---
Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
index 7822a806ea0a..b27a1d4fec78 100644
--- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
+++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
@@ -4,7 +4,9 @@ Required properties:
- compatible: should be one of:
"fsl,imx8-ddr-pmu"
- "fsl,imx8m-ddr-pmu"
+ "fsl,imx8mq-ddr-pmu"
+ "fsl,imx8mm-ddr-pmu"
+ "fsl,imx8mn-ddr-pmu"
"fsl,imx8mp-ddr-pmu"
- reg: physical address and size
--
2.17.1
On Tue, May 12, 2020 at 03:31:14PM +0800, Joakim Zhang wrote:
> Update compatible string according to driver change.`
Why?
You are breaking compatibility.
>
> Signed-off-by: Joakim Zhang <[email protected]>
> ---
> Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> index 7822a806ea0a..b27a1d4fec78 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> @@ -4,7 +4,9 @@ Required properties:
>
> - compatible: should be one of:
> "fsl,imx8-ddr-pmu"
> - "fsl,imx8m-ddr-pmu"
> + "fsl,imx8mq-ddr-pmu"
> + "fsl,imx8mm-ddr-pmu"
> + "fsl,imx8mn-ddr-pmu"
> "fsl,imx8mp-ddr-pmu"
>
> - reg: physical address and size
> --
> 2.17.1
>
On 12/05/2020 08:31, Joakim Zhang wrote:
> Update compatible string according to driver change.`
>
> Signed-off-by: Joakim Zhang <[email protected]>
> ---
> Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> index 7822a806ea0a..b27a1d4fec78 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> @@ -4,7 +4,9 @@ Required properties:
>
Hi Joakim,
> - compatible: should be one of:
> "fsl,imx8-ddr-pmu"
> - "fsl,imx8m-ddr-pmu"
> + "fsl,imx8mq-ddr-pmu"
> + "fsl,imx8mm-ddr-pmu"
I noticed that some of the compat strings being added are used in imx
dtsi files today:
john@localhost:~/linux> git grep "fsl,imx8mm-ddr-pmu"
arch/arm64/boot/dts/freescale/imx8mm.dtsi: compatible =
"fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
Any specific reason why they are not described in the dt bindings already?
I don't follow dt so much anymore, so don't know the policies.
> + "fsl,imx8mn-ddr-pmu"
Thanks,
John
> -----Original Message-----
> From: John Garry <[email protected]>
> Sent: 2020年7月15日 19:04
> To: Joakim Zhang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: dl-linux-imx <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible
> string
>
> On 12/05/2020 08:31, Joakim Zhang wrote:
> > Update compatible string according to driver change.`
> >
> > Signed-off-by: Joakim Zhang <[email protected]>
> > ---
> > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > index 7822a806ea0a..b27a1d4fec78 100644
> > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > @@ -4,7 +4,9 @@ Required properties:
> >
>
> Hi Joakim,
>
> > - compatible: should be one of:
> > "fsl,imx8-ddr-pmu"
> > - "fsl,imx8m-ddr-pmu"
> > + "fsl,imx8mq-ddr-pmu"
> > + "fsl,imx8mm-ddr-pmu"
>
> I noticed that some of the compat strings being added are used in imx dtsi files
> today:
>
> john@localhost:~/linux> git grep "fsl,imx8mm-ddr-pmu"
> arch/arm64/boot/dts/freescale/imx8mm.dtsi: compatible =
> "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
>
> Any specific reason why they are not described in the dt bindings already?
>
> I don't follow dt so much anymore, so don't know the policies.
Hi John,
What I did is not standard, any compat string in dts file should be described in the dt bindings. I will keep in mind.
Best Regards,
Joakim Zhang
> > + "fsl,imx8mn-ddr-pmu"
>
> Thanks,
> John