2020-05-20 08:09:49

by Baoquan He

Subject: [PATCH] MAINTAINERS: add files related to kdump

Kdump is implemented based on kexec, however some files are only
related to crash dumping and missing, add them to KDUMP entry.

Signed-off-by: Baoquan He <[email protected]>
---
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 83cf5c43242a..2f9eefd33114 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9251,6 +9251,11 @@ L: [email protected]
S: Maintained
W: http://lse.sourceforge.net/kdump/
F: Documentation/admin-guide/kdump/
+F: fs/proc/vmcore.c
+F: include/linux/crash_core.h
+F: include/linux/crash_dump.h
+F: include/uapi/linux/vmcore.h
+F: kernel/crash.*

KEENE FM RADIO TRANSMITTER DRIVER
M: Hans Verkuil <[email protected]>
--
2.17.2

2020-05-20 09:17:01

by Dave Young

Subject: Re: [PATCH] MAINTAINERS: add files related to kdump

Hi Baoquan,
On 05/20/20 at 04:05pm, Baoquan He wrote:
> Kdump is implemented based on kexec, however some files are only
> related to crash dumping and missing, add them to KDUMP entry.
>
> Signed-off-by: Baoquan He <[email protected]>
> ---
> MAINTAINERS | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 83cf5c43242a..2f9eefd33114 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9251,6 +9251,11 @@ L: [email protected]
> S: Maintained
> W: http://lse.sourceforge.net/kdump/
> F: Documentation/admin-guide/kdump/
> +F: fs/proc/vmcore.c
> +F: include/linux/crash_core.h
> +F: include/linux/crash_dump.h
> +F: include/uapi/linux/vmcore.h
> +F: kernel/crash.*

ls kernel/crash.*
ls: cannot access 'kernel/crash.*': No such file or directory

But ls kernel/crash*
kernel/crash_core.c kernel/crash_dump.c

Thanks
Dave

2020-05-20 09:46:09

by Baoquan He

Subject: Re: [PATCH] MAINTAINERS: add files related to kdump

On 05/20/20 at 05:14pm, Dave Young wrote:
> Hi Baoquan,
> On 05/20/20 at 04:05pm, Baoquan He wrote:
> > Kdump is implemented based on kexec, however some files are only
> > related to crash dumping and missing, add them to KDUMP entry.
> >
> > Signed-off-by: Baoquan He <[email protected]>
> > ---
> > MAINTAINERS | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 83cf5c43242a..2f9eefd33114 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9251,6 +9251,11 @@ L: [email protected]
> > S: Maintained
> > W: http://lse.sourceforge.net/kdump/
> > F: Documentation/admin-guide/kdump/
> > +F: fs/proc/vmcore.c
> > +F: include/linux/crash_core.h
> > +F: include/linux/crash_dump.h
> > +F: include/uapi/linux/vmcore.h
> > +F: kernel/crash.*
>
> ls kernel/crash.*
> ls: cannot access 'kernel/crash.*': No such file or directory
>
> But ls kernel/crash*
> kernel/crash_core.c kernel/crash_dump.c

Is below patten ok? Surely kernel/crash* is also OK to me. Thanks.

F: kernel/crash_*.c

2020-05-20 09:50:36

by Dave Young

Subject: Re: [PATCH] MAINTAINERS: add files related to kdump

On 05/20/20 at 05:43pm, Baoquan He wrote:
> On 05/20/20 at 05:14pm, Dave Young wrote:
> > Hi Baoquan,
> > On 05/20/20 at 04:05pm, Baoquan He wrote:
> > > Kdump is implemented based on kexec, however some files are only
> > > related to crash dumping and missing, add them to KDUMP entry.
> > >
> > > Signed-off-by: Baoquan He <[email protected]>
> > > ---
> > > MAINTAINERS | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 83cf5c43242a..2f9eefd33114 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -9251,6 +9251,11 @@ L: [email protected]
> > > S: Maintained
> > > W: http://lse.sourceforge.net/kdump/
> > > F: Documentation/admin-guide/kdump/
> > > +F: fs/proc/vmcore.c
> > > +F: include/linux/crash_core.h
> > > +F: include/linux/crash_dump.h
> > > +F: include/uapi/linux/vmcore.h
> > > +F: kernel/crash.*
> >
> > ls kernel/crash.*
> > ls: cannot access 'kernel/crash.*': No such file or directory
> >
> > But ls kernel/crash*
> > kernel/crash_core.c kernel/crash_dump.c
>
> Is below patten ok? Surely kernel/crash* is also OK to me. Thanks.
>
> F: kernel/crash_*.c

Yes, looks good, thanks!

Acked-by: Dave Young <[email protected]>

Thanks
Dave

2020-05-20 10:39:23

by Baoquan He

Subject: [PATCH v2] MAINTAINERS: add files related to kdump

Kdump is implemented based on kexec, however some files are only
related to crash dumping and missing, add them to KDUMP entry.

Signed-off-by: Baoquan He <[email protected]>
Acked-by: Dave Young <[email protected]>
---
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 83cf5c43242a..29c26e7a7a47 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9251,6 +9251,11 @@ L: [email protected]
S: Maintained
W: http://lse.sourceforge.net/kdump/
F: Documentation/admin-guide/kdump/
+F: fs/proc/vmcore.c
+F: include/linux/crash_core.h
+F: include/linux/crash_dump.h
+F: include/uapi/linux/vmcore.h
+F: kernel/crash_*.c

KEENE FM RADIO TRANSMITTER DRIVER
M: Hans Verkuil <[email protected]>
--
2.17.2