2020-05-25 06:32:59

by 王文虎

Subject: [PATCH] drivers: ipa: print dev_err info accurately

Print certain name string instead of hard-coded "memory" for dev_err
output, which would be more accurate and helpful for debugging.

Signed-off-by: Wang Wenhu <[email protected]>
Cc: Alex Elder <[email protected]>
---
drivers/net/ipa/ipa_clock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index ddbd687fe64b..749ff5668e37 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name)

path = of_icc_get(dev, name);
if (IS_ERR(path))
- dev_err(dev, "error %ld getting memory interconnect\n",
- PTR_ERR(path));
+ dev_err(dev, "error %ld getting %s interconnect\n",
+ PTR_ERR(path), name);

return path;
}
--
2.17.1

2020-05-26 00:54:01

by Alex Elder

Subject: Re: [PATCH] drivers: ipa: print dev_err info accurately

On 5/25/20 1:29 AM, Wang Wenhu wrote:
> Print certain name string instead of hard-coded "memory" for dev_err
> output, which would be more accurate and helpful for debugging.
>
> Signed-off-by: Wang Wenhu <[email protected]>
> Cc: Alex Elder <[email protected]>

Good idea.

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/net/ipa/ipa_clock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index ddbd687fe64b..749ff5668e37 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name)
>
> path = of_icc_get(dev, name);
> if (IS_ERR(path))
> - dev_err(dev, "error %ld getting memory interconnect\n",
> - PTR_ERR(path));
> + dev_err(dev, "error %ld getting %s interconnect\n",
> + PTR_ERR(path), name);
>
> return path;
> }
>

2020-05-26 01:06:15

by David Miller

Subject: Re: [PATCH] drivers: ipa: print dev_err info accurately

From: Wang Wenhu <[email protected]>
Date: Sun, 24 May 2020 23:29:51 -0700

> Print certain name string instead of hard-coded "memory" for dev_err
> output, which would be more accurate and helpful for debugging.
>
> Signed-off-by: Wang Wenhu <[email protected]>

Applied to net-next, thanks.