2020-05-27 16:04:10

by Chuhong Yuan

Subject: [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c

rv3028_probe() misses a check for devm_regmap_init_i2c().
Add the missed check to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/rtc/rtc-rv3028.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
index a0ddc86c975a..ec84db0b3d7a 100644
--- a/drivers/rtc/rtc-rv3028.c
+++ b/drivers/rtc/rtc-rv3028.c
@@ -755,6 +755,8 @@ static int rv3028_probe(struct i2c_client *client)
return -ENOMEM;

rv3028->regmap = devm_regmap_init_i2c(client, &regmap_config);
+ if (IS_ERR(rv3028->regmap))
+ return PTR_ERR(rv3028->regmap);

i2c_set_clientdata(client, rv3028);

--
2.26.2

2020-05-30 01:59:24

by Alexandre Belloni

Subject: Re: [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c

On Wed, 27 May 2020 23:07:04 +0800, Chuhong Yuan wrote:
> rv3028_probe() misses a check for devm_regmap_init_i2c().
> Add the missed check to fix it.

Applied, thanks!

[1/1] rtc: rv3028: add the missed check for devm_regmap_init_i2c

Best regards,
--
Alexandre Belloni <[email protected]>