2020-06-01 19:29:15

by Lubomir Rintel

Subject: [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans

When there's a single interrupt for all the DMA channels, the
unsuccessful attempt to request separate IRQs emits useless warnings:

[ 1.370381] mmp-pdma d4000000.dma: IRQ index 1 not found
...
[ 1.412398] mmp-pdma d4000000.dma: IRQ index 15 not found
[ 1.418308] mmp-pdma d4000000.dma: initialized 16 channels

Avoid that, treating the IRQs as optional.

Signed-off-by: Lubomir Rintel <[email protected]>
---
drivers/dma/mmp_pdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index ad06f260e907d..41c542eaa23a5 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c
@@ -1060,7 +1060,7 @@ static int mmp_pdma_probe(struct platform_device *op)
pdev->dma_channels = dma_channels;

for (i = 0; i < dma_channels; i++) {
- if (platform_get_irq(op, i) > 0)
+ if (platform_get_irq_optional(op, i) > 0)
irq_num++;
}

--
2.26.2

2020-06-16 16:32:14

by Vinod Koul

Subject: Re: [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans

On 01-06-20, 21:23, Lubomir Rintel wrote:
> When there's a single interrupt for all the DMA channels, the
> unsuccessful attempt to request separate IRQs emits useless warnings:
>
> [ 1.370381] mmp-pdma d4000000.dma: IRQ index 1 not found
> ...
> [ 1.412398] mmp-pdma d4000000.dma: IRQ index 15 not found
> [ 1.418308] mmp-pdma d4000000.dma: initialized 16 channels
>
> Avoid that, treating the IRQs as optional.

Applied, thanks

--
~Vinod