Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/infiniband/hw/qib/qib_pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
index 3dc6ce033319..3e22dd274fb3 100644
--- a/drivers/infiniband/hw/qib/qib_pcie.c
+++ b/drivers/infiniband/hw/qib/qib_pcie.c
@@ -213,7 +213,7 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent)
u16 linkstat, speed;
int nvec;
int maxvec;
- unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
+ unsigned int flags = PCI_IRQ_MSI_TYPES;
if (!pci_is_pcie(dd->pcidev)) {
qib_dev_err(dd, "Can't find PCI Express capability!\n");
--
2.17.2
On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
<[email protected]> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
...
> - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
> + unsigned int flags = PCI_IRQ_MSI_TYPES;
>
> if (!pci_is_pcie(dd->pcidev)) {
> qib_dev_err(dd, "Can't find PCI Express capability!\n");
Internally I have proposed at last this:
convert the following
if (dd->flags & QIB_HAS_INTX)
flags |= PCI_IRQ_LEGACY;
to
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_ALL_TYPES;
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_MSI_TYPES;
--
With Best Regards,
Andy Shevchenko
On Tue, Jun 2, 2020 at 6:35 PM Andy Shevchenko
<[email protected]> wrote:
> On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
> <[email protected]> wrote:
...
> if (dd->flags & QIB_HAS_INTX)
> flags = PCI_IRQ_ALL_TYPES;
> if (dd->flags & QIB_HAS_INTX)
This line should be 'else'.
> flags = PCI_IRQ_MSI_TYPES;
--
With Best Regards,
Andy Shevchenko