2020-06-03 21:47:15

by Jonathan Corbet

Subject: [PATCH] irqchip: Fix the description of the Loongson PCH MSI controller

Commit 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller") appears to
suffer from a lack of copy-and-paste fixup, with the result that the
KConfig description describes the wrong device. Avoid potential user
confusion by getting the right acronym where it was meant to be.

Signed-off-by: Jonathan Corbet <[email protected]>
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 66b9a68f5e9f..d7c920afcfcb 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -550,7 +550,7 @@ config LOONGSON_PCH_PIC
Support for the Loongson PCH PIC Controller.

config LOONGSON_PCH_MSI
- bool "Loongson PCH PIC Controller"
+ bool "Loongson PCH MSI Controller"
depends on MACH_LOONGSON64 || COMPILE_TEST
depends on PCI
default MACH_LOONGSON64
--
2.26.2

2020-06-03 23:28:39

by Jiaxun Yang

Subject: Re: [PATCH] irqchip: Fix the description of the Loongson PCH MSI controller

On Wed, 3 Jun 2020 15:44:06 -0600
Jonathan Corbet <[email protected]> wrote:

> Commit 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller")
> appears to suffer from a lack of copy-and-paste fixup, with the
> result that the KConfig description describes the wrong device.
> Avoid potential user confusion by getting the right acronym where it
> was meant to be.

Hi??

Thanks for addressing.

There is already a commit[1] fixing that. It will appear in Linus tree
very soon.


[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=5a7f796d4f2028bde4c2ac778dfe0456851871b2

- Jiaxun

>
> Signed-off-by: Jonathan Corbet <[email protected]>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 66b9a68f5e9f..d7c920afcfcb 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -550,7 +550,7 @@ config LOONGSON_PCH_PIC
> Support for the Loongson PCH PIC Controller.
>
> config LOONGSON_PCH_MSI
> - bool "Loongson PCH PIC Controller"
> + bool "Loongson PCH MSI Controller"
> depends on MACH_LOONGSON64 || COMPILE_TEST
> depends on PCI
> default MACH_LOONGSON64