2020-06-07 09:08:43

by YoungJun.park

Subject: [PATCH] overlay: remove not necessary lock check.

dir is always locked until "out_unlock" label.
So lock check is not needed.

Signed-off-by: youngjun <[email protected]>
---
fs/overlayfs/super.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 732ad5495c92..43257c18fe26 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -615,10 +615,8 @@ static struct dentry *ovl_workdir_create(struct ovl_fs *ofs,
struct dentry *work;
int err;
bool retried = false;
- bool locked = false;

inode_lock_nested(dir, I_MUTEX_PARENT);
- locked = true;

retry:
work = lookup_one_len(name, ofs->workbasedir, strlen(name));
@@ -680,9 +678,7 @@ static struct dentry *ovl_workdir_create(struct ovl_fs *ofs,
goto out_err;
}
out_unlock:
- if (locked)
- inode_unlock(dir);
-
+ inode_unlock(dir);
return work;

out_dput:
--
2.17.1

2020-06-08 08:02:41

by Miklos Szeredi

Subject: Re: [PATCH] overlay: remove not necessary lock check.

On Sun, Jun 7, 2020 at 11:04 AM youngjun <[email protected]> wrote:
>
> dir is always locked until "out_unlock" label.
> So lock check is not needed.

Thanks, applied.

Miklos