2020-06-09 12:50:56

by SeongJae Park

[permalink] [raw]
Subject: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

From: SeongJae Park <[email protected]>

This commit recommends the patches to replace 'blacklist' and
'whitelist' with the 'blocklist' and 'allowlist', because the new
suggestions are incontrovertible, doesn't make people hurt, and more
self-explanatory.

Signed-off-by: SeongJae Park <[email protected]>
---
scripts/spelling.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index d9cd24cf0d40..ea785568d8b8 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -230,6 +230,7 @@ beter||better
betweeen||between
bianries||binaries
bitmast||bitmask
+blacklist||blocklist
boardcast||broadcast
borad||board
boundry||boundary
@@ -1495,6 +1496,7 @@ whcih||which
whenver||whenever
wheter||whether
whe||when
+whitelist||allowlist
wierd||weird
wiil||will
wirte||write
--
2.17.1


2020-06-09 13:04:38

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On Tue, Jun 09, 2020 at 02:25:49PM +0200, SeongJae Park wrote:
> From: SeongJae Park <[email protected]>
>
> This commit recommends the patches to replace 'blacklist' and
> 'whitelist' with the 'blocklist' and 'allowlist', because the new
> suggestions are incontrovertible, doesn't make people hurt, and more
> self-explanatory.
>
> Signed-off-by: SeongJae Park <[email protected]>
> ---
> scripts/spelling.txt | 2 ++
> 1 file changed, 2 insertions(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

2020-06-09 13:08:38

by SeongJae Park

[permalink] [raw]
Subject: Re: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On Tue, 9 Jun 2020 14:56:07 +0200 Greg KH <[email protected]> wrote:

> On Tue, Jun 09, 2020 at 02:25:49PM +0200, SeongJae Park wrote:
> > From: SeongJae Park <[email protected]>
> >
> > This commit recommends the patches to replace 'blacklist' and
> > 'whitelist' with the 'blocklist' and 'allowlist', because the new
> > suggestions are incontrovertible, doesn't make people hurt, and more
> > self-explanatory.
> >
> > Signed-off-by: SeongJae Park <[email protected]>
> > ---
> > scripts/spelling.txt | 2 ++
> > 1 file changed, 2 insertions(+)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.

Sorry, I only mistakenly Cc-ed [email protected]. Please don't pull this
in the stable tree.


Thanks,
SeongJae Park

>
> </formletter>
>

2020-06-10 01:38:49

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On Tue, 2020-06-09 at 14:25 +0200, SeongJae Park wrote:
> From: SeongJae Park <[email protected]>
>
> This commit recommends the patches to replace 'blacklist' and
> 'whitelist' with the 'blocklist' and 'allowlist', because the new
> suggestions are incontrovertible, doesn't make people hurt, and more
> self-explanatory.

nack. Spelling is for typos not for politics.

> Signed-off-by: SeongJae Park <[email protected]>
> ---
> scripts/spelling.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index d9cd24cf0d40..ea785568d8b8 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -230,6 +230,7 @@ beter||better
> betweeen||between
> bianries||binaries
> bitmast||bitmask
> +blacklist||blocklist
> boardcast||broadcast
> borad||board
> boundry||boundary
> @@ -1495,6 +1496,7 @@ whcih||which
> whenver||whenever
> wheter||whether
> whe||when
> +whitelist||allowlist
> wierd||weird
> wiil||will
> wirte||write

2020-06-10 05:36:03

by SeongJae Park

[permalink] [raw]
Subject: Re: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On Tue, 09 Jun 2020 18:35:46 -0700 Joe Perches <[email protected]> wrote:

> On Tue, 2020-06-09 at 14:25 +0200, SeongJae Park wrote:
> > From: SeongJae Park <[email protected]>
> >
> > This commit recommends the patches to replace 'blacklist' and
> > 'whitelist' with the 'blocklist' and 'allowlist', because the new
> > suggestions are incontrovertible, doesn't make people hurt, and more
> > self-explanatory.
>
> nack. Spelling is for typos not for politics.

Agreed, I'm abusing the spell checking. I personally believe the terms will
eventually removed from the dictionary and become typos, though.

I will update checkpatch to support deprecated terms checking, and set the
'blacklist' and 'whitelist' as the deprecated terms in the next spin.


Thanks,
SeongJae Park

>
> > Signed-off-by: SeongJae Park <[email protected]>
> > ---
> > scripts/spelling.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> > index d9cd24cf0d40..ea785568d8b8 100644
> > --- a/scripts/spelling.txt
> > +++ b/scripts/spelling.txt
> > @@ -230,6 +230,7 @@ beter||better
> > betweeen||between
> > bianries||binaries
> > bitmast||bitmask
> > +blacklist||blocklist
> > boardcast||broadcast
> > borad||board
> > boundry||boundary
> > @@ -1495,6 +1496,7 @@ whcih||which
> > whenver||whenever
> > wheter||whether
> > whe||when
> > +whitelist||allowlist
> > wierd||weird
> > wiil||will
> > wirte||write

2020-06-10 09:20:46

by SeongJae Park

[permalink] [raw]
Subject: Re: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On Wed, 10 Jun 2020 10:50:24 +0200 Jiri Slaby <[email protected]> wrote:

> On 09. 06. 20, 14:25, SeongJae Park wrote:
> > From: SeongJae Park <[email protected]>
> >
> > This commit recommends the patches to replace 'blacklist' and
> > 'whitelist' with the 'blocklist' and 'allowlist', because the new
> > suggestions are incontrovertible, doesn't make people hurt, and more
> > self-explanatory.
>
> Sorry, but no, it's definitely not.
>
> > Signed-off-by: SeongJae Park <[email protected]>
> > ---
> > scripts/spelling.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> > index d9cd24cf0d40..ea785568d8b8 100644
> > --- a/scripts/spelling.txt
> > +++ b/scripts/spelling.txt
> > @@ -230,6 +230,7 @@ beter||better
> > betweeen||between
> > bianries||binaries
> > bitmast||bitmask
> > +blacklist||blocklist
>
> Blocklist means a list of blocks here.

How about 'denylist', then?

>
> > boardcast||broadcast
> > borad||board
> > boundry||boundary
> > @@ -1495,6 +1496,7 @@ whcih||which
> > whenver||whenever
> > wheter||whether
> > whe||when
> > +whitelist||allowlist
>
> Wut? allowlist I am seeing for the 1st time.

Wouldn't it easy to infer the intention, though?

>
> Some purists, linguists, and politicians are true fellows at times, or
> at least they think so. This comes in waves and even if they try hard,
> people won't adopt their nonsense. Like we, Czechs, still call piano by
> German Klavier, and not břinkoklapka, suggested in 19th century (among
> many others) by the horny extremists.
>
> Shall we stop using black, white, blue, and other colors only because
> they relate to skin color of avatars now? I doubt that.

Well, I have no strong opinion on this, but... if some people are really being
hurt by use of some terms and we could avoid spread of the term with only
little cost, I believe it's worth to make the change.


Thanks,
SeongJae Park

>
> thanks,
> --
> js
> suse labs

2020-06-10 14:40:14

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH v2] scripts/spelling: Recommend blocklist/allowlist instead of blacklist/whitelist

On 09. 06. 20, 14:25, SeongJae Park wrote:
> From: SeongJae Park <[email protected]>
>
> This commit recommends the patches to replace 'blacklist' and
> 'whitelist' with the 'blocklist' and 'allowlist', because the new
> suggestions are incontrovertible, doesn't make people hurt, and more
> self-explanatory.

Sorry, but no, it's definitely not.

> Signed-off-by: SeongJae Park <[email protected]>
> ---
> scripts/spelling.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index d9cd24cf0d40..ea785568d8b8 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -230,6 +230,7 @@ beter||better
> betweeen||between
> bianries||binaries
> bitmast||bitmask
> +blacklist||blocklist

Blocklist means a list of blocks here.

> boardcast||broadcast
> borad||board
> boundry||boundary
> @@ -1495,6 +1496,7 @@ whcih||which
> whenver||whenever
> wheter||whether
> whe||when
> +whitelist||allowlist

Wut? allowlist I am seeing for the 1st time.

Some purists, linguists, and politicians are true fellows at times, or
at least they think so. This comes in waves and even if they try hard,
people won't adopt their nonsense. Like we, Czechs, still call piano by
German Klavier, and not b?inkoklapka, suggested in 19th century (among
many others) by the horny extremists.

Shall we stop using black, white, blue, and other colors only because
they relate to skin color of avatars now? I doubt that.

thanks,
--
js
suse labs