2020-06-10 13:22:02

by Zhenzhong Duan

Subject: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled

If one MCE error has been processed in kernel, it's not necessory
to pass it to user level mcelog.

Signed-off-by: Zhenzhong Duan <[email protected]>
---
drivers/edac/skx_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
index 46be1a7..8c0165b 100644
--- a/drivers/edac/skx_common.c
+++ b/drivers/edac/skx_common.c
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,

skx_mce_output_error(mci, mce, &res);

- return NOTIFY_DONE;
+ /* Advice mcelog that the error were handled */
+ return NOTIFY_STOP;
}

void skx_remove(void)
--
1.8.3.1

2020-06-10 14:29:13

by Borislav Petkov

Subject: Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled

On Wed, Jun 10, 2020 at 02:58:01PM +0800, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
>
> Signed-off-by: Zhenzhong Duan <[email protected]>
> ---
> drivers/edac/skx_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>
> skx_mce_output_error(mci, mce, &res);
>
> - return NOTIFY_DONE;
> + /* Advice mcelog that the error were handled */
> + return NOTIFY_STOP;
> }
>
> void skx_remove(void)
> --

No, we won't be doing that anymore. See here:

https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568

it should appear mainline soon-ish, I hope.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette