2020-06-11 19:22:47

by Keyur Patel

Subject: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent

Since the commit 7723f4c ("driver core: platform: Add an error message
to platform_get_irq*()") platform_get_irq() started issuing an error message.
Thus, there is no need to have the same in the driver.

Signed-off-by: Keyur Patel <[email protected]>
---
drivers/memory/tegra/mc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index ec8403557ed4..f519c0987485 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
}

mc->irq = platform_get_irq(pdev, 0);
- if (mc->irq < 0) {
- dev_err(&pdev->dev, "interrupt not specified\n");
+ if (mc->irq < 0)
return mc->irq;
- }

WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");

--
2.26.2

2020-06-12 14:18:04

by Dmitry Osipenko

Subject: Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent

11.06.2020 22:07, Keyur Patel пишет:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
>
> Signed-off-by: Keyur Patel <[email protected]>
> ---
> drivers/memory/tegra/mc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> index ec8403557ed4..f519c0987485 100644
> --- a/drivers/memory/tegra/mc.c
> +++ b/drivers/memory/tegra/mc.c
> @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev)
> }
>
> mc->irq = platform_get_irq(pdev, 0);
> - if (mc->irq < 0) {
> - dev_err(&pdev->dev, "interrupt not specified\n");
> + if (mc->irq < 0)
> return mc->irq;
> - }
>
> WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n");
>
>

Reviewed-by: Dmitry Osipenko <[email protected]>