2020-06-10 17:33:38

by Álvaro Fernández Rojas

Subject: [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
to enable/disable certain components in order to save power.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
---
v3: fix reg maxItems and quote #power-domain-cells.
v2: Add separate YAML file.

.../bindings/soc/bcm/brcm,bcm63xx-power.yaml | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
new file mode 100644
index 000000000000..fd4204d9aaf6
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: BCM63xx power domain driver
+
+maintainers:
+ - Álvaro Fernández Rojas <[email protected]>
+
+description: |
+ BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
+ to enable/disable certain components in order to save power.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - brcm,bcm6318-power-controller
+ - brcm,bcm6328-power-controller
+ - brcm,bcm6362-power-controller
+ - brcm,bcm63268-power-controller
+
+ reg:
+ maxItems: 2
+
+ "#power-domain-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - "#power-domain-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ periph_pwr: power-controller@10001848 {
+ compatible = "brcm,bcm6328-power-controller";
+ reg = <0x10001848 0x4>;
+ #power-domain-cells = <1>;
+ };
--
2.26.2

2020-06-12 21:58:21

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

On Wed, 10 Jun 2020 19:16:22 +0200, ?lvaro Fern?ndez Rojas wrote:
> BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
> to enable/disable certain components in order to save power.
>
> Signed-off-by: ?lvaro Fern?ndez Rojas <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>
> ---
> v3: fix reg maxItems and quote #power-domain-cells.
> v2: Add separate YAML file.
>
> .../bindings/soc/bcm/brcm,bcm63xx-power.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
>


My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/soc/bcm/brcm,bcm63xx-power.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.example.dt.yaml: power-controller@10001848: reg: [[268441672, 4]] is too short


See https://patchwork.ozlabs.org/patch/1307099

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

2020-06-12 22:00:04

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/9] dt-bindings: soc: brcm: add BCM63xx power domain binding

On Wed, Jun 10, 2020 at 07:16:22PM +0200, ?lvaro Fern?ndez Rojas wrote:
> BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
> to enable/disable certain components in order to save power.
>
> Signed-off-by: ?lvaro Fern?ndez Rojas <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>
> ---
> v3: fix reg maxItems and quote #power-domain-cells.
> v2: Add separate YAML file.
>
> .../bindings/soc/bcm/brcm,bcm63xx-power.yaml | 44 +++++++++++++++++++

Goes in bindings/power/

> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
> new file mode 100644
> index 000000000000..fd4204d9aaf6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later

Okay with GPLv9? Dual license new bindings:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: BCM63xx power domain driver
> +
> +maintainers:
> + - ?lvaro Fern?ndez Rojas <[email protected]>
> +
> +description: |
> + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
> + to enable/disable certain components in order to save power.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - brcm,bcm6318-power-controller
> + - brcm,bcm6328-power-controller
> + - brcm,bcm6362-power-controller
> + - brcm,bcm63268-power-controller
> +
> + reg:
> + maxItems: 2
> +
> + "#power-domain-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - "#power-domain-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + periph_pwr: power-controller@10001848 {
> + compatible = "brcm,bcm6328-power-controller";
> + reg = <0x10001848 0x4>;
> + #power-domain-cells = <1>;
> + };
> --
> 2.26.2
>