2020-06-15 13:55:52

by Charles Keepax

Subject: [PATCH v2 4/4] mfd: madera: Fix minor formatting issues

The mfd_cell structures inconsistently use commas on single entries in
the table, make this consistent by always using a comma. Also remove an
extra blank line.

Signed-off-by: Charles Keepax <[email protected]>
---

Changes since v1:
- Added some additional commit description.
- Move the removing and unused forward declaration into a new patch.

Thanks,
Charles

drivers/mfd/madera-core.c | 12 ++++++------
drivers/mfd/madera-i2c.c | 1 -
2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 7e0835cb062b1..4724c1a01a39f 100644
--- a/drivers/mfd/madera-core.c
+++ b/drivers/mfd/madera-core.c
@@ -44,7 +44,7 @@ static const char * const madera_core_supplies[] = {
};

static const struct mfd_cell madera_ldo1_devs[] = {
- { .name = "madera-ldo1" },
+ { .name = "madera-ldo1", },
};

static const char * const cs47l15_supplies[] = {
@@ -55,8 +55,8 @@ static const char * const cs47l15_supplies[] = {

static const struct mfd_cell cs47l15_devs[] = {
{ .name = "madera-pinctrl", },
- { .name = "madera-irq" },
- { .name = "madera-gpio" },
+ { .name = "madera-irq", },
+ { .name = "madera-gpio", },
{
.name = "madera-extcon",
.parent_supplies = cs47l15_supplies,
@@ -108,7 +108,7 @@ static const char * const cs47l85_supplies[] = {
static const struct mfd_cell cs47l85_devs[] = {
{ .name = "madera-pinctrl", },
{ .name = "madera-irq", },
- { .name = "madera-micsupp" },
+ { .name = "madera-micsupp", },
{ .name = "madera-gpio", },
{
.name = "madera-extcon",
@@ -155,10 +155,10 @@ static const char * const cs47l92_supplies[] = {
};

static const struct mfd_cell cs47l92_devs[] = {
- { .name = "madera-pinctrl" },
+ { .name = "madera-pinctrl", },
{ .name = "madera-irq", },
{ .name = "madera-micsupp", },
- { .name = "madera-gpio" },
+ { .name = "madera-gpio", },
{
.name = "madera-extcon",
.parent_supplies = cs47l92_supplies,
diff --git a/drivers/mfd/madera-i2c.c b/drivers/mfd/madera-i2c.c
index 6b965eb034b6c..7df5b9ba58554 100644
--- a/drivers/mfd/madera-i2c.c
+++ b/drivers/mfd/madera-i2c.c
@@ -88,7 +88,6 @@ static int madera_i2c_probe(struct i2c_client *i2c,
if (!madera)
return -ENOMEM;

-
madera->regmap = devm_regmap_init_i2c(i2c, regmap_16bit_config);
if (IS_ERR(madera->regmap)) {
ret = PTR_ERR(madera->regmap);
--
2.11.0

2020-06-16 08:07:19

by Lee Jones

Subject: Re: [PATCH v2 4/4] mfd: madera: Fix minor formatting issues

On Mon, 15 Jun 2020, Charles Keepax wrote:

> The mfd_cell structures inconsistently use commas on single entries in
> the table, make this consistent by always using a comma. Also remove an
> extra blank line.
>
> Signed-off-by: Charles Keepax <[email protected]>
> ---
>
> Changes since v1:
> - Added some additional commit description.
> - Move the removing and unused forward declaration into a new patch.
>
> Thanks,
> Charles
>
> drivers/mfd/madera-core.c | 12 ++++++------
> drivers/mfd/madera-i2c.c | 1 -
> 2 files changed, 6 insertions(+), 7 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog