2020-06-15 16:00:15

by Drew Fustini

[permalink] [raw]
Subject: [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
RGMII mode") the networking is broken on the BeagleBone AI which has
the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
phy-mode = "rgmii" to phy-mode = "rgmii-rxid".

Note: Grygorii made a similar DT fix for other AM57xx boards with a
different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
on boards with ksz9031 phy").

[0] https://git.io/Jf7PX

Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
Cc: Vinod Koul <[email protected]>
Reviewed-by: Grygorii Strashko <[email protected]>
Signed-off-by: Robert Nelson <[email protected]>
Signed-off-by: Drew Fustini <[email protected]>
---
V2:
- fix formatting of commit reference
- add Review-by: from Grygorii

arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
index 9877d7709d41..4c51c6b05e64 100644
--- a/arch/arm/boot/dts/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
@@ -505,7 +505,7 @@ &mac {

&cpsw_emac0 {
phy-handle = <&phy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-rxid";
};

&ocp {
--
2.25.1


2020-06-16 16:14:46

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

* Drew Fustini <[email protected]> [200615 08:58]:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
>
> Note: Grygorii made a similar DT fix for other AM57xx boards with a
> different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
> on boards with ksz9031 phy").
>
> [0] https://git.io/Jf7PX
>
> Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
> Cc: Vinod Koul <[email protected]>
> Reviewed-by: Grygorii Strashko <[email protected]>
> Signed-off-by: Robert Nelson <[email protected]>
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> V2:
> - fix formatting of commit reference
> - add Review-by: from Grygorii

Thanks applying into fixes.

Regards,

Tony