2020-06-04 01:55:55

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 0/3] Convert i.MX/MXS mmc binding to json-schema

This patch series converts i.MX and MXS mmc binding to json-schema,
fix some minor issues in original binding doc, such as node name should be 'mmc',
compatible name for i.MX27, reg/interrupts should be required properties etc..

Compared to V1, this patch series adds "unevaluatedProperties: false" for
each binding doc.

Anson Huang (3):
dt-bindings: mmc: Convert imx esdhc to json-schema
dt-bindings: mmc: Convert imx mmc to json-schema
dt-bindings: mmc: Convert mxs mmc to json-schema

.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 67 -----------
.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 124 +++++++++++++++++++++
.../devicetree/bindings/mmc/fsl-imx-mmc.txt | 23 ----
.../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 53 +++++++++
Documentation/devicetree/bindings/mmc/mxs-mmc.txt | 27 -----
Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 58 ++++++++++
6 files changed, 235 insertions(+), 117 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.yaml

--
2.7.4


2020-06-04 01:56:17

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 2/3] dt-bindings: mmc: Convert imx mmc to json-schema

Convert the i.MX MMC binding to DT schema format using json-schema

Signed-off-by: Anson Huang <[email protected]>
---
Changes since V1:
- add "unevaluatedProperties: false".
---
.../devicetree/bindings/mmc/fsl-imx-mmc.txt | 23 ----------
.../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 53 ++++++++++++++++++++++
2 files changed, 53 insertions(+), 23 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
deleted file mode 100644
index 184ccff..0000000
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Freescale Secure Digital Host Controller for i.MX2/3 series
-
-This file documents differences to the properties defined in mmc.txt.
-
-Required properties:
-- compatible : Should be "fsl,<chip>-mmc", chip can be imx21 or imx31
-
-Optional properties:
-- dmas: One DMA phandle with arguments as defined by the devicetree bindings
- of the used DMA controller.
-- dma-names: Has to be "rx-tx".
-
-Example:
-
-sdhci1: sdhci@10014000 {
- compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
- reg = <0x10014000 0x1000>;
- interrupts = <11>;
- dmas = <&dma 7>;
- dma-names = "rx-tx";
- bus-width = <4>;
- cd-gpios = <&gpio3 29>;
-};
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
new file mode 100644
index 0000000..ffa1627
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale Secure Digital Host Controller for i.MX2/3 series
+
+maintainers:
+ - Markus Pargmann <[email protected]>
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+properties:
+ compatible:
+ oneOf:
+ - const: fsl,imx21-mmc
+ - const: fsl,imx31-mmc
+ - items:
+ - const: fsl,imx27-mmc
+ - const: fsl,imx21-mmc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ dmas:
+ maxItems: 1
+
+ dma-names:
+ const: rx-tx
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ mmc@10014000 {
+ compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+ reg = <0x10014000 0x1000>;
+ interrupts = <11>;
+ dmas = <&dma 7>;
+ dma-names = "rx-tx";
+ bus-width = <4>;
+ cd-gpios = <&gpio3 29>;
+ };
--
2.7.4

2020-06-04 01:57:59

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 1/3] dt-bindings: mmc: Convert imx esdhc to json-schema

Convert the i.MX ESDHC binding to DT schema format using json-schema

Signed-off-by: Anson Huang <[email protected]>
---
Changes since V1:
- add "unevaluatedProperties: false".
---
.../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 67 -----------
.../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 124 +++++++++++++++++++++
2 files changed, 124 insertions(+), 67 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
deleted file mode 100644
index de1b8bd..0000000
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
+++ /dev/null
@@ -1,67 +0,0 @@
-* Freescale Enhanced Secure Digital Host Controller (eSDHC) for i.MX
-
-The Enhanced Secure Digital Host Controller on Freescale i.MX family
-provides an interface for MMC, SD, and SDIO types of memory cards.
-
-This file documents differences between the core properties described
-by mmc.txt and the properties used by the sdhci-esdhc-imx driver.
-
-Required properties:
-- compatible : Should be "fsl,<chip>-esdhc", the supported chips include
- "fsl,imx25-esdhc"
- "fsl,imx35-esdhc"
- "fsl,imx51-esdhc"
- "fsl,imx53-esdhc"
- "fsl,imx6q-usdhc"
- "fsl,imx6sl-usdhc"
- "fsl,imx6sx-usdhc"
- "fsl,imx6ull-usdhc"
- "fsl,imx7d-usdhc"
- "fsl,imx7ulp-usdhc"
- "fsl,imx8mq-usdhc"
- "fsl,imx8mm-usdhc"
- "fsl,imx8mn-usdhc"
- "fsl,imx8mp-usdhc"
- "fsl,imx8qm-usdhc"
- "fsl,imx8qxp-usdhc"
-
-Optional properties:
-- fsl,wp-controller : Indicate to use controller internal write protection
-- fsl,delay-line : Specify the number of delay cells for override mode.
- This is used to set the clock delay for DLL(Delay Line) on override mode
- to select a proper data sampling window in case the clock quality is not good
- due to signal path is too long on the board. Please refer to eSDHC/uSDHC
- chapter, DLL (Delay Line) section in RM for details.
-- voltage-ranges : Specify the voltage range in case there are software
- transparent level shifters on the outputs of the controller. Two cells are
- required, first cell specifies minimum slot voltage (mV), second cell
- specifies maximum slot voltage (mV). Several ranges could be specified.
-- fsl,tuning-start-tap: Specify the start dealy cell point when send first CMD19
- in tuning procedure.
-- fsl,tuning-step: Specify the increasing delay cell steps in tuning procedure.
- The uSDHC use one delay cell as default increasing step to do tuning process.
- This property allows user to change the tuning step to more than one delay
- cells which is useful for some special boards or cards when the default
- tuning step can't find the proper delay window within limited tuning retries.
-- fsl,strobe-dll-delay-target: Specify the strobe dll control slave delay target.
- This delay target programming host controller loopback read clock, and this
- property allows user to change the delay target for the strobe input read clock.
- If not use this property, driver default set the delay target to value 7.
- Only eMMC HS400 mode need to take care of this property.
-
-Examples:
-
-esdhc@70004000 {
- compatible = "fsl,imx51-esdhc";
- reg = <0x70004000 0x4000>;
- interrupts = <1>;
- fsl,wp-controller;
-};
-
-esdhc@70008000 {
- compatible = "fsl,imx51-esdhc";
- reg = <0x70008000 0x4000>;
- interrupts = <2>;
- cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */
- wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */
-};
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
new file mode 100644
index 0000000..74db24aa
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale Enhanced Secure Digital Host Controller (eSDHC) for i.MX
+
+maintainers:
+ - Shawn Guo <[email protected]>
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+description: |
+ The Enhanced Secure Digital Host Controller on Freescale i.MX family
+ provides an interface for MMC, SD, and SDIO types of memory cards.
+
+ This file documents differences between the core properties described
+ by mmc.txt and the properties used by the sdhci-esdhc-imx driver.
+
+properties:
+ compatible:
+ enum:
+ - fsl,imx25-esdhc
+ - fsl,imx35-esdhc
+ - fsl,imx51-esdhc
+ - fsl,imx53-esdhc
+ - fsl,imx6q-usdhc
+ - fsl,imx6sl-usdhc
+ - fsl,imx6sx-usdhc
+ - fsl,imx6ull-usdhc
+ - fsl,imx7d-usdhc
+ - fsl,imx7ulp-usdhc
+ - fsl,imx8mq-usdhc
+ - fsl,imx8mm-usdhc
+ - fsl,imx8mn-usdhc
+ - fsl,imx8mp-usdhc
+ - fsl,imx8qm-usdhc
+ - fsl,imx8qxp-usdhc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ fsl,wp-controller:
+ description: |
+ boolean, if present, indicate to use controller internal write protection.
+ type: boolean
+
+ fsl,delay-line:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Specify the number of delay cells for override mode.
+ This is used to set the clock delay for DLL(Delay Line) on override mode
+ to select a proper data sampling window in case the clock quality is not good
+ due to signal path is too long on the board. Please refer to eSDHC/uSDHC
+ chapter, DLL (Delay Line) section in RM for details.
+ default: 0
+
+ voltage-ranges:
+ $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
+ description: |
+ Specify the voltage range in case there are software
+ transparent level shifters on the outputs of the controller. Two cells are
+ required, first cell specifies minimum slot voltage (mV), second cell
+ specifies maximum slot voltage (mV). Several ranges could be specified.
+ items:
+ items:
+ - description: value for minimum slot voltage
+ - description: value for maximum slot voltage
+ maxItems: 1
+
+ fsl,tuning-start-tap:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Specify the start dealy cell point when send first CMD19 in tuning procedure.
+ default: 0
+
+ fsl,tuning-step:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Specify the increasing delay cell steps in tuning procedure.
+ The uSDHC use one delay cell as default increasing step to do tuning process.
+ This property allows user to change the tuning step to more than one delay
+ cells which is useful for some special boards or cards when the default
+ tuning step can't find the proper delay window within limited tuning retries.
+ default: 0
+
+ fsl,strobe-dll-delay-target:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Specify the strobe dll control slave delay target.
+ This delay target programming host controller loopback read clock, and this
+ property allows user to change the delay target for the strobe input read clock.
+ If not use this property, driver default set the delay target to value 7.
+ Only eMMC HS400 mode need to take care of this property.
+ default: 0
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ mmc@70004000 {
+ compatible = "fsl,imx51-esdhc";
+ reg = <0x70004000 0x4000>;
+ interrupts = <1>;
+ fsl,wp-controller;
+ };
+
+ mmc@70008000 {
+ compatible = "fsl,imx51-esdhc";
+ reg = <0x70008000 0x4000>;
+ interrupts = <2>;
+ cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */
+ wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */
+ };
--
2.7.4

2020-06-04 02:01:41

by Anson Huang

[permalink] [raw]
Subject: [PATCH V2 3/3] dt-bindings: mmc: Convert mxs mmc to json-schema

Convert the MXS MMC binding to DT schema format using json-schema

Signed-off-by: Anson Huang <[email protected]>
---
Changes since V1:
- add "unevaluatedProperties: false".
---
Documentation/devicetree/bindings/mmc/mxs-mmc.txt | 27 ----------
Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 58 ++++++++++++++++++++++
2 files changed, 58 insertions(+), 27 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.txt
create mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.yaml

diff --git a/Documentation/devicetree/bindings/mmc/mxs-mmc.txt b/Documentation/devicetree/bindings/mmc/mxs-mmc.txt
deleted file mode 100644
index 515addc..0000000
--- a/Documentation/devicetree/bindings/mmc/mxs-mmc.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-* Freescale MXS MMC controller
-
-The Freescale MXS Synchronous Serial Ports (SSP) can act as a MMC controller
-to support MMC, SD, and SDIO types of memory cards.
-
-This file documents differences between the core properties in mmc.txt
-and the properties used by the mxsmmc driver.
-
-Required properties:
-- compatible: Should be "fsl,<chip>-mmc". The supported chips include
- imx23 and imx28.
-- interrupts: Should contain ERROR interrupt number
-- dmas: DMA specifier, consisting of a phandle to DMA controller node
- and SSP DMA channel ID.
- Refer to dma.txt and fsl-mxs-dma.txt for details.
-- dma-names: Must be "rx-tx".
-
-Examples:
-
-ssp0: ssp@80010000 {
- compatible = "fsl,imx28-mmc";
- reg = <0x80010000 2000>;
- interrupts = <96>;
- dmas = <&dma_apbh 0>;
- dma-names = "rx-tx";
- bus-width = <8>;
-};
diff --git a/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml
new file mode 100644
index 0000000..1cccc04
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/mxs-mmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MXS MMC controller
+
+maintainers:
+ - Shawn Guo <[email protected]>
+
+description: |
+ The Freescale MXS Synchronous Serial Ports (SSP) can act as a MMC controller
+ to support MMC, SD, and SDIO types of memory cards.
+
+ This file documents differences between the core properties in mmc.txt
+ and the properties used by the mxsmmc driver.
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+properties:
+ compatible:
+ enum:
+ - fsl,imx23-mmc
+ - fsl,imx28-mmc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ dmas:
+ maxItems: 1
+
+ dma-names:
+ const: rx-tx
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - dmas
+ - dma-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ mmc@80010000 {
+ compatible = "fsl,imx28-mmc";
+ reg = <0x80010000 2000>;
+ interrupts = <96>;
+ dmas = <&dma_apbh 0>;
+ dma-names = "rx-tx";
+ bus-width = <8>;
+ };
--
2.7.4

2020-06-15 16:29:13

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH V2 1/3] dt-bindings: mmc: Convert imx esdhc to json-schema

On Thu, Jun 04, 2020 at 09:41:24AM +0800, Anson Huang wrote:
> Convert the i.MX ESDHC binding to DT schema format using json-schema
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> Changes since V1:
> - add "unevaluatedProperties: false".
> ---
> .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 67 -----------
> .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 124 +++++++++++++++++++++
> 2 files changed, 124 insertions(+), 67 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> deleted file mode 100644
> index de1b8bd..0000000
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt
> +++ /dev/null
> @@ -1,67 +0,0 @@
> -* Freescale Enhanced Secure Digital Host Controller (eSDHC) for i.MX
> -
> -The Enhanced Secure Digital Host Controller on Freescale i.MX family
> -provides an interface for MMC, SD, and SDIO types of memory cards.
> -
> -This file documents differences between the core properties described
> -by mmc.txt and the properties used by the sdhci-esdhc-imx driver.
> -
> -Required properties:
> -- compatible : Should be "fsl,<chip>-esdhc", the supported chips include
> - "fsl,imx25-esdhc"
> - "fsl,imx35-esdhc"
> - "fsl,imx51-esdhc"
> - "fsl,imx53-esdhc"
> - "fsl,imx6q-usdhc"
> - "fsl,imx6sl-usdhc"
> - "fsl,imx6sx-usdhc"
> - "fsl,imx6ull-usdhc"
> - "fsl,imx7d-usdhc"
> - "fsl,imx7ulp-usdhc"
> - "fsl,imx8mq-usdhc"
> - "fsl,imx8mm-usdhc"
> - "fsl,imx8mn-usdhc"
> - "fsl,imx8mp-usdhc"
> - "fsl,imx8qm-usdhc"
> - "fsl,imx8qxp-usdhc"
> -
> -Optional properties:
> -- fsl,wp-controller : Indicate to use controller internal write protection
> -- fsl,delay-line : Specify the number of delay cells for override mode.
> - This is used to set the clock delay for DLL(Delay Line) on override mode
> - to select a proper data sampling window in case the clock quality is not good
> - due to signal path is too long on the board. Please refer to eSDHC/uSDHC
> - chapter, DLL (Delay Line) section in RM for details.
> -- voltage-ranges : Specify the voltage range in case there are software
> - transparent level shifters on the outputs of the controller. Two cells are
> - required, first cell specifies minimum slot voltage (mV), second cell
> - specifies maximum slot voltage (mV). Several ranges could be specified.
> -- fsl,tuning-start-tap: Specify the start dealy cell point when send first CMD19
> - in tuning procedure.
> -- fsl,tuning-step: Specify the increasing delay cell steps in tuning procedure.
> - The uSDHC use one delay cell as default increasing step to do tuning process.
> - This property allows user to change the tuning step to more than one delay
> - cells which is useful for some special boards or cards when the default
> - tuning step can't find the proper delay window within limited tuning retries.
> -- fsl,strobe-dll-delay-target: Specify the strobe dll control slave delay target.
> - This delay target programming host controller loopback read clock, and this
> - property allows user to change the delay target for the strobe input read clock.
> - If not use this property, driver default set the delay target to value 7.
> - Only eMMC HS400 mode need to take care of this property.
> -
> -Examples:
> -
> -esdhc@70004000 {
> - compatible = "fsl,imx51-esdhc";
> - reg = <0x70004000 0x4000>;
> - interrupts = <1>;
> - fsl,wp-controller;
> -};
> -
> -esdhc@70008000 {
> - compatible = "fsl,imx51-esdhc";
> - reg = <0x70008000 0x4000>;
> - interrupts = <2>;
> - cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */
> - wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */
> -};
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> new file mode 100644
> index 0000000..74db24aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -0,0 +1,124 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale Enhanced Secure Digital Host Controller (eSDHC) for i.MX
> +
> +maintainers:
> + - Shawn Guo <[email protected]>
> +
> +allOf:
> + - $ref: "mmc-controller.yaml"
> +
> +description: |
> + The Enhanced Secure Digital Host Controller on Freescale i.MX family
> + provides an interface for MMC, SD, and SDIO types of memory cards.
> +
> + This file documents differences between the core properties described
> + by mmc.txt and the properties used by the sdhci-esdhc-imx driver.
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx25-esdhc
> + - fsl,imx35-esdhc
> + - fsl,imx51-esdhc
> + - fsl,imx53-esdhc
> + - fsl,imx6q-usdhc
> + - fsl,imx6sl-usdhc
> + - fsl,imx6sx-usdhc
> + - fsl,imx6ull-usdhc
> + - fsl,imx7d-usdhc
> + - fsl,imx7ulp-usdhc
> + - fsl,imx8mq-usdhc
> + - fsl,imx8mm-usdhc
> + - fsl,imx8mn-usdhc
> + - fsl,imx8mp-usdhc
> + - fsl,imx8qm-usdhc
> + - fsl,imx8qxp-usdhc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + fsl,wp-controller:
> + description: |
> + boolean, if present, indicate to use controller internal write protection.
> + type: boolean
> +
> + fsl,delay-line:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specify the number of delay cells for override mode.
> + This is used to set the clock delay for DLL(Delay Line) on override mode
> + to select a proper data sampling window in case the clock quality is not good
> + due to signal path is too long on the board. Please refer to eSDHC/uSDHC
> + chapter, DLL (Delay Line) section in RM for details.
> + default: 0
> +
> + voltage-ranges:
> + $ref: '/schemas/types.yaml#/definitions/uint32-matrix'
> + description: |
> + Specify the voltage range in case there are software
> + transparent level shifters on the outputs of the controller. Two cells are
> + required, first cell specifies minimum slot voltage (mV), second cell
> + specifies maximum slot voltage (mV). Several ranges could be specified.
> + items:
> + items:
> + - description: value for minimum slot voltage
> + - description: value for maximum slot voltage
> + maxItems: 1

This contradicts 'Several ranges could be specified.'

> +
> + fsl,tuning-start-tap:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specify the start dealy cell point when send first CMD19 in tuning procedure.

typo: delay

> + default: 0
> +
> + fsl,tuning-step:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specify the increasing delay cell steps in tuning procedure.
> + The uSDHC use one delay cell as default increasing step to do tuning process.
> + This property allows user to change the tuning step to more than one delay
> + cells which is useful for some special boards or cards when the default
> + tuning step can't find the proper delay window within limited tuning retries.
> + default: 0
> +
> + fsl,strobe-dll-delay-target:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specify the strobe dll control slave delay target.
> + This delay target programming host controller loopback read clock, and this
> + property allows user to change the delay target for the strobe input read clock.
> + If not use this property, driver default set the delay target to value 7.
> + Only eMMC HS400 mode need to take care of this property.
> + default: 0
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mmc@70004000 {
> + compatible = "fsl,imx51-esdhc";
> + reg = <0x70004000 0x4000>;
> + interrupts = <1>;
> + fsl,wp-controller;
> + };
> +
> + mmc@70008000 {
> + compatible = "fsl,imx51-esdhc";
> + reg = <0x70008000 0x4000>;
> + interrupts = <2>;
> + cd-gpios = <&gpio1 6 0>; /* GPIO1_6 */
> + wp-gpios = <&gpio1 5 0>; /* GPIO1_5 */
> + };
> --
> 2.7.4
>

2020-06-15 16:31:12

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH V2 2/3] dt-bindings: mmc: Convert imx mmc to json-schema

On Thu, 04 Jun 2020 09:41:25 +0800, Anson Huang wrote:
> Convert the i.MX MMC binding to DT schema format using json-schema
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> Changes since V1:
> - add "unevaluatedProperties: false".
> ---
> .../devicetree/bindings/mmc/fsl-imx-mmc.txt | 23 ----------
> .../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 53 ++++++++++++++++++++++
> 2 files changed, 53 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml
>

Applied, thanks!

2020-06-15 16:46:45

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH V2 3/3] dt-bindings: mmc: Convert mxs mmc to json-schema

On Thu, 04 Jun 2020 09:41:26 +0800, Anson Huang wrote:
> Convert the MXS MMC binding to DT schema format using json-schema
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> Changes since V1:
> - add "unevaluatedProperties: false".
> ---
> Documentation/devicetree/bindings/mmc/mxs-mmc.txt | 27 ----------
> Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 58 ++++++++++++++++++++++
> 2 files changed, 58 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/mxs-mmc.yaml
>

Applied, thanks!