2020-06-16 01:53:38

by Jacky Hu

Subject: [PATCH] pinctrl: amd: fix npins for uart0 in kerncz_groups

uart0_pins is defined as:
static const unsigned uart0_pins[] = {135, 136, 137, 138, 139};

which npins is wronly specified as 9 later
{
.name = "uart0",
.pins = uart0_pins,
.npins = 9,
},

npins should be 5 instead of 9 according to the definition.

Signed-off-by: Jacky Hu <[email protected]>
---
drivers/pinctrl/pinctrl-amd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-amd.h b/drivers/pinctrl/pinctrl-amd.h
index 3e5760f1a715..d4a192df5fab 100644
--- a/drivers/pinctrl/pinctrl-amd.h
+++ b/drivers/pinctrl/pinctrl-amd.h
@@ -252,7 +252,7 @@ static const struct amd_pingroup kerncz_groups[] = {
{
.name = "uart0",
.pins = uart0_pins,
- .npins = 9,
+ .npins = 5,
},
{
.name = "uart1",
--
2.27.0

2020-06-22 07:41:13

by Linus Walleij

Subject: Re: [PATCH] pinctrl: amd: fix npins for uart0 in kerncz_groups

On Tue, Jun 16, 2020 at 3:50 AM Jacky Hu <[email protected]> wrote:

> uart0_pins is defined as:
> static const unsigned uart0_pins[] = {135, 136, 137, 138, 139};
>
> which npins is wronly specified as 9 later
> {
> .name = "uart0",
> .pins = uart0_pins,
> .npins = 9,
> },
>
> npins should be 5 instead of 9 according to the definition.
>
> Signed-off-by: Jacky Hu <[email protected]>

Seems like an obvious bug so patch applied for fixes.

Yours,
Linus Walleij