2020-06-18 15:31:50

by Codrin Ciubotariu

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: at91: sama5d2_xplained: Remove pdmic node

The PDMIC needs PDM microphones to work. sama5d2 xplained doesn't have
such microphones, so there is no reason to enable PDMIC and take the
pins since there is no-one using them.

Signed-off-by: Codrin Ciubotariu <[email protected]>
---

Changes in v2:
- rebased on top of at91-dt;
- added more details in the commit description;
- changed subject from:
"[PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node""
to
"[PATCH v2] ARM: dts: at91: sama5d2_xplained: Remove pdmic node"


arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ----------------
1 file changed, 16 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index 0e17df568d0b..058fae1b4a76 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -168,16 +168,6 @@ timer1: timer@1 {
};
};

- pdmic@f8018000 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_pdmic_default>;
- atmel,model = "PDMIC @ sama5d2_xplained";
- atmel,mic-min-freq = <1000000>;
- atmel,mic-max-freq = <3246000>;
- atmel,mic-offset = <0x0>;
- status = "okay";
- };
-
uart1: serial@f8020000 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1_default>;
@@ -599,12 +589,6 @@ pinctrl_macb0_phy_irq: macb0_phy_irq {
bias-disable;
};

- pinctrl_pdmic_default: pdmic_default {
- pinmux = <PIN_PB26__PDMIC_DAT>,
- <PIN_PB27__PDMIC_CLK>;
- bias-disable;
- };
-
pinctrl_qspi0_default: qspi0_default {
sck_cs {
pinmux = <PIN_PA22__QSPI0_SCK>,
--
2.25.1


2020-06-26 20:48:54

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2_xplained: Remove pdmic node

On Thu, 18 Jun 2020 18:28:45 +0300, Codrin Ciubotariu wrote:
> The PDMIC needs PDM microphones to work. sama5d2 xplained doesn't have
> such microphones, so there is no reason to enable PDMIC and take the
> pins since there is no-one using them.

Applied, thanks!

[1/1] ARM: dts: at91: sama5d2_xplained: Remove pdmic node
commit: 51139cc82c8d6edec034a6c2401090070195fa13

Best regards,
--
Alexandre Belloni <[email protected]>