2020-06-19 08:53:29

by chenweilong

Subject: [PATCH] virtio-mem: Fix build error due to improper use 'select'

As noted in:
https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
"select should be used with care. select will force a symbol to a
value without visiting the dependencies."
Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
Otherwise it will cause an error:
https://bugzilla.kernel.org/show_bug.cgi?id=208245

Signed-off-by: Weilong Chen <[email protected]>
---
drivers/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 5809e5f5b157..5c92e4a50882 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -85,7 +85,7 @@ config VIRTIO_MEM
depends on VIRTIO
depends on MEMORY_HOTPLUG_SPARSE
depends on MEMORY_HOTREMOVE
- select CONTIG_ALLOC
+ depends on CONTIG_ALLOC
help
This driver provides access to virtio-mem paravirtualized memory
devices, allowing to hotplug and hotunplug memory.
--
2.17.1

2020-06-19 12:52:05

by David Hildenbrand

Subject: Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'

On 19.06.20 10:03, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."

Right, rings a bell.

> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245

Thanks!

Acked-by: David Hildenbrand <[email protected]>

>
> Signed-off-by: Weilong Chen <[email protected]>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
> depends on VIRTIO
> depends on MEMORY_HOTPLUG_SPARSE
> depends on MEMORY_HOTREMOVE
> - select CONTIG_ALLOC
> + depends on CONTIG_ALLOC
> help
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
>


--
Thanks,

David / dhildenb

2020-06-19 18:11:58

by Michael S. Tsirkin

Subject: Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'

On Fri, Jun 19, 2020 at 04:03:33PM +0800, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."
> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245
>
> Signed-off-by: Weilong Chen <[email protected]>

Cc virtio mem maintainer:
M: David Hildenbrand <[email protected]>


> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
> depends on VIRTIO
> depends on MEMORY_HOTPLUG_SPARSE
> depends on MEMORY_HOTREMOVE
> - select CONTIG_ALLOC
> + depends on CONTIG_ALLOC
> help
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
> --
> 2.17.1