2020-06-19 13:29:12

by Denis Efremov (Oracle)

Subject: [PATCH] coccinelle: api/kstrdup: fix coccinelle position

There is a typo in rule r2. Position p1 should be attached to kzalloc()
call.

Fixes: 29a36d4dec6c ("scripts/coccinelle: improve the coverage of some semantic patches")
Signed-off-by: Denis Efremov <[email protected]>
---
scripts/coccinelle/api/kstrdup.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
index 19f2645e6076..3c6dc5469ee4 100644
--- a/scripts/coccinelle/api/kstrdup.cocci
+++ b/scripts/coccinelle/api/kstrdup.cocci
@@ -66,7 +66,7 @@ position p1,p2;

* x = strlen(from) + 1;
... when != \( x = E1 \| from = E1 \)
-* to = \(kmalloc@p1\|kzalloc@p2\)(x,flag);
+* to = \(kmalloc@p1\|kzalloc@p1\)(x,flag);
... when != \(x = E2 \| from = E2 \| to = E2 \)
if (to==NULL || ...) S
... when != \(x = E3 \| from = E3 \| to = E3 \)
--
2.26.2

2020-06-19 15:49:08

by Markus Elfring

Subject: Re: [PATCH] coccinelle: api/kstrdup: fix coccinelle position

> There is a typo in rule r2. Position p1 should be attached to kzalloc() call.

I find such a suggestion reasonable for an implementation detail.

I would find an other patch subject clearer.


How do you think about to move the specification “@p1” out of SmPL disjunctions?

Regards,
Markus

2020-06-20 04:35:56

by Julia Lawall

Subject: Re: [Cocci] [PATCH] coccinelle: api/kstrdup: fix coccinelle position

On Fri, 19 Jun 2020, Denis Efremov wrote:

> There is a typo in rule r2. Position p1 should be attached to kzalloc()
> call.

Clearly. Thanks. Applied.

julia


>
> Fixes: 29a36d4dec6c ("scripts/coccinelle: improve the coverage of some semantic patches")
> Signed-off-by: Denis Efremov <[email protected]>
> ---
> scripts/coccinelle/api/kstrdup.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
> index 19f2645e6076..3c6dc5469ee4 100644
> --- a/scripts/coccinelle/api/kstrdup.cocci
> +++ b/scripts/coccinelle/api/kstrdup.cocci
> @@ -66,7 +66,7 @@ position p1,p2;
>
> * x = strlen(from) + 1;
> ... when != \( x = E1 \| from = E1 \)
> -* to = \(kmalloc@p1\|kzalloc@p2\)(x,flag);
> +* to = \(kmalloc@p1\|kzalloc@p1\)(x,flag);
> ... when != \(x = E2 \| from = E2 \| to = E2 \)
> if (to==NULL || ...) S
> ... when != \(x = E3 \| from = E3 \| to = E3 \)
> --
> 2.26.2
>
> _______________________________________________
> Cocci mailing list
> [email protected]
> https://systeme.lip6.fr/mailman/listinfo/cocci
>