2020-06-20 05:05:39

by Prashant Malani

Subject: [PATCH] platform/chrome: cros_ec_typec: Make configure_mux static

Since cros_typec_configure_mux() is only used in cros-ec-typec,
it should be marked static.

Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Prashant Malani <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 509fc761906b..1df1386f32e4 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -428,9 +428,9 @@ static int cros_typec_enable_dp(struct cros_typec_data *typec,
return typec_mux_set(port->mux, &port->state);
}

-int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
- uint8_t mux_flags,
- struct ec_response_usb_pd_control_v2 *pd_ctrl)
+static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
+ uint8_t mux_flags,
+ struct ec_response_usb_pd_control_v2 *pd_ctrl)
{
struct cros_typec_port *port = typec->ports[port_num];
enum typec_orientation orientation;
--
2.27.0.111.gc72c7da667-goog

2020-06-25 11:58:12

by Enric Balletbo i Serra

Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Make configure_mux static

Hi Prashant,

On 20/6/20 4:00, Prashant Malani wrote:
> Since cros_typec_configure_mux() is only used in cros-ec-typec,
> it should be marked static.
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Prashant Malani <[email protected]>

Applied for 5.9

> ---
> drivers/platform/chrome/cros_ec_typec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 509fc761906b..1df1386f32e4 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -428,9 +428,9 @@ static int cros_typec_enable_dp(struct cros_typec_data *typec,
> return typec_mux_set(port->mux, &port->state);
> }
>
> -int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> - uint8_t mux_flags,
> - struct ec_response_usb_pd_control_v2 *pd_ctrl)
> +static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> + uint8_t mux_flags,
> + struct ec_response_usb_pd_control_v2 *pd_ctrl)
> {
> struct cros_typec_port *port = typec->ports[port_num];
> enum typec_orientation orientation;
>