2020-06-21 15:33:14

by Gaurav Singh

Subject: [PATCH] Fix check in ethtool_rx_flow_rule_create

Fix check in ethtool_rx_flow_rule_create

Signed-off-by: Gaurav Singh <[email protected]>
---
net/ethtool/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index b5df90c981c2..21d5fc0f6bb3 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2978,7 +2978,7 @@ ethtool_rx_flow_rule_create(const struct ethtool_rx_flow_spec_input *input)
sizeof(match->mask.ipv6.dst));
}
if (memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr)) ||
- memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr))) {
+ memcmp(v6_m_spec->ip6dst, &zero_addr, sizeof(zero_addr))) {
match->dissector.used_keys |=
BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS);
match->dissector.offset[FLOW_DISSECTOR_KEY_IPV6_ADDRS] =
--
2.17.1

2020-06-23 04:20:16

by David Miller

Subject: Re: [PATCH] Fix check in ethtool_rx_flow_rule_create

From: Gaurav Singh <[email protected]>
Date: Sun, 21 Jun 2020 11:30:17 -0400

> Fix check in ethtool_rx_flow_rule_create
>
> Signed-off-by: Gaurav Singh <[email protected]>

Applied and queued up for -stable with the following Fixes: tag added:

Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")

Thank you.