2020-06-22 02:26:43

by Gaurav Singh

Subject: [PATCH] [net/sched] tcindex_change: Remove redundant null check

arg cannot be NULL since its already being dereferenced
before. Remove the redundant NULL check.

Signed-off-by: Gaurav Singh <[email protected]>
---
net/sched/cls_tcindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index 61e95029c18f..78bec347b8b6 100644
--- a/net/sched/cls_tcindex.c
+++ b/net/sched/cls_tcindex.c
@@ -533,7 +533,7 @@ tcindex_change(struct net *net, struct sk_buff *in_skb,

pr_debug("tcindex_change(tp %p,handle 0x%08x,tca %p,arg %p),opt %p,"
"p %p,r %p,*arg %p\n",
- tp, handle, tca, arg, opt, p, r, arg ? *arg : NULL);
+ tp, handle, tca, arg, opt, p, r, *arg);

if (!opt)
return 0;
--
2.17.1

2020-06-23 04:00:41

by David Miller

Subject: Re: [PATCH] [net/sched] tcindex_change: Remove redundant null check

From: Gaurav Singh <[email protected]>
Date: Sun, 21 Jun 2020 22:24:30 -0400

> arg cannot be NULL since its already being dereferenced
> before. Remove the redundant NULL check.
>
> Signed-off-by: Gaurav Singh <[email protected]>

Applied, thank you.