Hi all,
After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
12 | #include "client.h"
| ^~~~~~~~~~
drivers/hid/intel-ish-hid/ipc/pci-ish.c:22:10: fatal error: ishtp-dev.h: No such file or directory
22 | #include "ishtp-dev.h"
| ^~~~~~~~~~~~~
I don't know what caused it, but commit
470376737e88 ("HID: allow building hid.ko as an external module")
did not fix it. BTW, I build with "make O=...".
I have used the hid tree from next-20200618 for today.
BTW, the hid tree really needs cleaning up, it contains merge commits dating
back to April 2018 :-(
$ git rev-list --count origin/master..hid/for-next
301
$ git rev-list --no-merges --count origin/master..hid/for-next
12
--
Cheers,
Stephen Rothwell
Hi all,
On Sun, 21 Jun 2020 14:04:21 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
> 12 | #include "client.h"
> | ^~~~~~~~~~
> drivers/hid/intel-ish-hid/ipc/pci-ish.c:22:10: fatal error: ishtp-dev.h: No such file or directory
> 22 | #include "ishtp-dev.h"
> | ^~~~~~~~~~~~~
>
> I don't know what caused it, but commit
>
> 470376737e88 ("HID: allow building hid.ko as an external module")
>
> did not fix it. BTW, I build with "make O=...".
>
> I have used the hid tree from next-20200618 for today.
>
> BTW, the hid tree really needs cleaning up, it contains merge commits dating
> back to April 2018 :-(
>
> $ git rev-list --count origin/master..hid/for-next
> 301
> $ git rev-list --no-merges --count origin/master..hid/for-next
> 12
I am still getting this failure.
--
Cheers,
Stephen Rothwell
[adding Cristian, the author of the patch]
On Tue, Jun 23, 2020 at 2:37 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Sun, 21 Jun 2020 14:04:21 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
> > 12 | #include "client.h"
> > | ^~~~~~~~~~
> > drivers/hid/intel-ish-hid/ipc/pci-ish.c:22:10: fatal error: ishtp-dev.h: No such file or directory
> > 22 | #include "ishtp-dev.h"
> > | ^~~~~~~~~~~~~
> >
> > I don't know what caused it, but commit
> >
> > 470376737e88 ("HID: allow building hid.ko as an external module")
I am under the impression that this patch is causing the issue.
I am tempted to revert it (and force push the branch hid/for-5.9/core)
given that the 0-day bot also complained.
> >
> > did not fix it. BTW, I build with "make O=...".
> >
> > I have used the hid tree from next-20200618 for today.
> >
> > BTW, the hid tree really needs cleaning up, it contains merge commits dating
> > back to April 2018 :-(
We are carefully not force pushing the hid/for-next branch, and all
the merges you are seeing there are the various merges we do after
including a patch that will be sent to linus later. Our for-next
branch never gets merged into for-linus, we handle that separately.
I always thought you prefer not having forced push on the for-next
branch. But if you rather us overwriting the tip of the branch at
every commit, we can do it for sure.
For reference, the way we handle branches are:
- master branch follows Linus' when there is an upstream merge of the
hid/for-linus branch
- every single commit goes into a branch named
for-<kernel_version>/<feature_name>
- those branches are created on top of current master and are never rebased
- every time we add a patch (series) on top of a feature branch, we
merge that into hid/for-next
- when we need to send a pull request to Linus, we merge the matching
"for-<kernel_version>/*" branches into hid/for-linus
This allows to keep a clear view of what is scheduled to be sent. But
the counterpart is that the hid/for-next branch never gets merged back
into hid/for-linus.
Cheers,
Benjamin
> >
> > $ git rev-list --count origin/master..hid/for-next
> > 301
> > $ git rev-list --no-merges --count origin/master..hid/for-next
> > 12
>
> I am still getting this failure.
>
> --
> Cheers,
> Stephen Rothwell
On Tue, 23 Jun 2020, Stephen Rothwell wrote:
> > I don't know what caused it, but commit
> >
> > 470376737e88 ("HID: allow building hid.ko as an external module")
> >
> > did not fix it. BTW, I build with "make O=...".
That's actually the patch that almost certainly broke it.
CCing Cristian (author of that patch) and Nathan, who apparently sent a
fixup patch for this, but I haven't seen it, as our corporate mailserver
had severe issues yesterday.
If there is no resolution by tomorrow, we'll just drop it.
--
Jiri Kosina
SUSE Labs
Hi Jiri and Cristian,
On Wed, Jun 24, 2020 at 12:13:57AM +0200, Jiri Kosina wrote:
> On Tue, 23 Jun 2020, Stephen Rothwell wrote:
>
> > > I don't know what caused it, but commit
> > >
> > > 470376737e88 ("HID: allow building hid.ko as an external module")
> > >
> > > did not fix it. BTW, I build with "make O=...".
>
> That's actually the patch that almost certainly broke it.
>
> CCing Cristian (author of that patch) and Nathan, who apparently sent a
> fixup patch for this, but I haven't seen it, as our corporate mailserver
> had severe issues yesterday.
>
> If there is no resolution by tomorrow, we'll just drop it.
>
> --
> Jiri Kosina
> SUSE Labs
>
Sorry, I was not clear in my message about what I was "fixing", which
was the fact that Cristian's initial reply was top posted, which I moved
to the bottom. I thought that would have been apparent in a mail client,
my bad :( I have not sent a fix for this issue.
Cheers,
Nathan
On Wed, 24 Jun 2020, Jiri Kosina wrote:
> > > I don't know what caused it, but commit
> > >
> > > 470376737e88 ("HID: allow building hid.ko as an external module")
> > >
> > > did not fix it. BTW, I build with "make O=...".
>
> That's actually the patch that almost certainly broke it.
>
> CCing Cristian (author of that patch) and Nathan, who apparently sent a
> fixup patch for this, but I haven't seen it, as our corporate mailserver
> had severe issues yesterday.
I've now dropped the patch from hid.git
--
Jiri Kosina
SUSE Labs
On Wed, Jun 24, 2020 at 09:30:23AM +0200, Jiri Kosina wrote:
> On Wed, 24 Jun 2020, Jiri Kosina wrote:
>
> > > > I don't know what caused it, but commit
> > > >
> > > > 470376737e88 ("HID: allow building hid.ko as an external module")
> > > >
> > > > did not fix it. BTW, I build with "make O=...".
> >
> > That's actually the patch that almost certainly broke it.
> >
> > CCing Cristian (author of that patch) and Nathan, who apparently sent a
> > fixup patch for this, but I haven't seen it, as our corporate mailserver
> > had severe issues yesterday.
>
> I've now dropped the patch from hid.git
>
> --
> Jiri Kosina
> SUSE Labs
>
Hi,
I tried several times, but I cannot reproduce. Attached the full compile
log.
Any pointers of why compilation fails on 0day-ci?
--
Cristian Klein, PhD
Cloud-Native Expert
Elastisys AB