2020-06-24 06:55:58

by Xu Wang

Subject: [PATCH] bcache: journel: use for_each_clear_bit() to simplify the code

Using for_each_clear_bit() to simplify the code.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/md/bcache/journal.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
index 90aac4e2333f..b01c953e214c 100644
--- a/drivers/md/bcache/journal.c
+++ b/drivers/md/bcache/journal.c
@@ -217,10 +217,7 @@ int bch_journal_read(struct cache_set *c, struct list_head *list)
*/
pr_debug("falling back to linear search\n");

- for (l = find_first_zero_bit(bitmap, ca->sb.njournal_buckets);
- l < ca->sb.njournal_buckets;
- l = find_next_zero_bit(bitmap, ca->sb.njournal_buckets,
- l + 1))
+ for_each_clear_bit(l, bitmap, ca->sb.njournal_buckets)
if (read_bucket(l))
goto bsearch;

--
2.17.1

2020-06-24 14:52:26

by Coly Li

Subject: Re: [PATCH] bcache: journel: use for_each_clear_bit() to simplify the code

On 2020/6/24 14:52, Xu Wang wrote:
> Using for_each_clear_bit() to simplify the code.
>
> Signed-off-by: Xu Wang <[email protected]>

It looks good to me, I will add it in my testing patches.

Thanks.

Coly Li

> ---
> drivers/md/bcache/journal.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c
> index 90aac4e2333f..b01c953e214c 100644
> --- a/drivers/md/bcache/journal.c
> +++ b/drivers/md/bcache/journal.c
> @@ -217,10 +217,7 @@ int bch_journal_read(struct cache_set *c, struct list_head *list)
> */
> pr_debug("falling back to linear search\n");
>
> - for (l = find_first_zero_bit(bitmap, ca->sb.njournal_buckets);
> - l < ca->sb.njournal_buckets;
> - l = find_next_zero_bit(bitmap, ca->sb.njournal_buckets,
> - l + 1))
> + for_each_clear_bit(l, bitmap, ca->sb.njournal_buckets)
> if (read_bucket(l))
> goto bsearch;
>
>