2020-06-25 12:43:12

by Stefan Berger

[permalink] [raw]
Subject: [PATCH v6 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

From: Stefan Berger <[email protected]>

This series of patches adds an optional extensions for the TPM2 ACPI table
with additional fields found in the TPM2 TCG ACPI specification (reference
is in the patch) that allow access to the log's address and its size. We
then modify the code that so far only enables access to a TPM 1.2's log for
a TPM2 as well. This then enables access to the TPM2's log on non-UEFI
system that for example run SeaBIOS.

Stefan

v5->v6:
- Moved extensions of TPM2 table into acpi_tpm2_phy.

v4->v5:
- Added R-bs and A-bs.

v3->v4:
- Repost as one series

v2->v3:
- Split the series into two separate patches
- Added comments to ACPI table fields
- Added check for null pointer to log area and zero log size

v1->v2:
- Repost of the series


Stefan Berger (2):
acpi: Extend TPM2 ACPI table with missing log fields
tpm: Add support for event log pointer found in TPM2 ACPI table

drivers/char/tpm/eventlog/acpi.c | 59 ++++++++++++++++++++------------
include/acpi/actbl3.h | 7 ++++
2 files changed, 45 insertions(+), 21 deletions(-)

--
2.26.2


2020-06-25 12:43:27

by Stefan Berger

[permalink] [raw]
Subject: [PATCH v6 1/2] acpi: Extend TPM2 ACPI table with missing log fields

From: Stefan Berger <[email protected]>

Recent extensions of the TPM2 ACPI table added 3 more fields
including 12 bytes of start method specific parameters and Log Area
Minimum Length (u32) and Log Area Start Address (u64). So, we define
a new structure acpi_tpm2_phy that holds these optional new fields.
The new fields allow non-UEFI systems to access the TPM2's log.

The specification that has the new fields is the following:
TCG ACPI Specification
Family "1.2" and "2.0"
Version 1.2, Revision 8

https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf

Signed-off-by: Stefan Berger <[email protected]>
Cc: [email protected]
Acked-by: Rafael J. Wysocki <[email protected]>
Cc: Jiandi An <[email protected]>
---
include/acpi/actbl3.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
index b0b163b9efc6..bdcac69fa6bd 100644
--- a/include/acpi/actbl3.h
+++ b/include/acpi/actbl3.h
@@ -415,6 +415,13 @@ struct acpi_table_tpm2 {
/* Platform-specific data follows */
};

+/* Optional trailer for revision 4 holding platform-specific data */
+struct acpi_tpm2_phy {
+ u8 start_method_specific[12];
+ u32 log_area_minimum_length;
+ u64 log_area_start_address;
+};
+
/* Values for start_method above */

#define ACPI_TPM2_NOT_ALLOWED 0
--
2.26.2

2020-06-25 23:39:42

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH v6 1/2] acpi: Extend TPM2 ACPI table with missing log fields

On Thu, Jun 25, 2020 at 08:42:21AM -0400, Stefan Berger wrote:
> From: Stefan Berger <[email protected]>
>
> Recent extensions of the TPM2 ACPI table added 3 more fields
> including 12 bytes of start method specific parameters and Log Area
> Minimum Length (u32) and Log Area Start Address (u64). So, we define
> a new structure acpi_tpm2_phy that holds these optional new fields.
> The new fields allow non-UEFI systems to access the TPM2's log.
>
> The specification that has the new fields is the following:
> TCG ACPI Specification
> Family "1.2" and "2.0"
> Version 1.2, Revision 8
>
> https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf
>
> Signed-off-by: Stefan Berger <[email protected]>
> Cc: [email protected]
> Acked-by: Rafael J. Wysocki <[email protected]>
> Cc: Jiandi An <[email protected]>

Reviewed-by: Jarkko Sakkinen <[email protected]>

/Jarkko