2020-06-28 13:44:38

by B K Karthik

[permalink] [raw]

Subject: [PATCH] init: main.c: Fixed a brace coding style issue.

---

Fixed a coding style issue.

Signed-off-by: B K Karthik <[email protected]>
---
init/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/init/main.c b/init/main.c
index 9127b240fd26..d8477fb95bec 100644
--- a/init/main.c
+++ b/init/main.c
@@ -385,11 +385,11 @@ static u32 boot_config_checksum(unsigned char *p, u32 size)
static int __init bootconfig_params(char *param, char *val,
const char *unused, void *arg)
{
- if (strcmp(param, "bootconfig") == 0) {
+ if (strcmp(param, "bootconfig") == 0)
bootconfig_found = true;
- } else if (strcmp(param, "--") == 0) {
+ else if (strcmp(param, "--") == 0)
initargs_found = true;
- }
+
return 0;
}

--
2.20.1

---

Attachments:

(No filename) (737.00 B)
signature.asc (673.00 B)
Download all attachments

2020-06-28 19:06:23

by Steven Rostedt

[permalink] [raw]

Subject: Re: [PATCH] init: main.c: Fixed a brace coding style issue.

---

On Sun, 28 Jun 2020 09:41:00 -0400
B K Karthik <[email protected]> wrote:

> Fixed a coding style issue.
>
> Signed-off-by: B K Karthik <[email protected]>
> ---
> init/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/init/main.c b/init/main.c
> index 9127b240fd26..d8477fb95bec 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -385,11 +385,11 @@ static u32 boot_config_checksum(unsigned char *p, u32 size)
> static int __init bootconfig_params(char *param, char *val,
> const char *unused, void *arg)
> {
> - if (strcmp(param, "bootconfig") == 0) {
> + if (strcmp(param, "bootconfig") == 0)
> bootconfig_found = true;
> - } else if (strcmp(param, "--") == 0) {
> + else if (strcmp(param, "--") == 0)
> initargs_found = true;
> - }
> +

NAK.

perhaps for simple if () ;else ; statements I'd be OK with this change,
but this is a if () ; else if () ; which is up to the preference of the
user. I find the brackets making it easier to see that this is not a
normal if () ; else ;

-- Steve


> return 0;
> }
>
> --
> 2.20.1
>