2020-06-29 19:25:24

by Amadeusz Sławiński

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] ALSA: compress: document the compress audio state machine

On 6/29/2020 11:34 AM, Vinod Koul wrote:
>
> Not sure, this is not in the version I posted, arrow is from setup ->
> prepare. See
https://lore.kernel.org/alsa-devel/[email protected]/
>
> I don't know how it got reversed in your version, maybe the MUA messed
> up??
>
Ah... I must have edited it myself when preparing edited version, sorry
for noise ;)


> a compr_write() moves from SETUP -> PREPARE. Fixing that above looks
> better version of mine..
Yes, I feel it is easier to understand, A redirect confused me for a
short bit when I first looked at graph and it can be easily avoided.


2020-06-29 21:41:51

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v4 1/3] ALSA: compress: document the compress audio state machine

On 29-06-20, 12:02, Amadeusz Sławiński wrote:
> On 6/29/2020 11:34 AM, Vinod Koul wrote:
> >
> > Not sure, this is not in the version I posted, arrow is from setup ->
> > prepare. See
> https://lore.kernel.org/alsa-devel/[email protected]/
> >
> > I don't know how it got reversed in your version, maybe the MUA messed
> > up??
> >
> Ah... I must have edited it myself when preparing edited version, sorry for
> noise ;)

No worries

>
> > a compr_write() moves from SETUP -> PREPARE. Fixing that above looks
> > better version of mine..
> Yes, I feel it is easier to understand, A redirect confused me for a short
> bit when I first looked at graph and it can be easily avoided.

Thanks for the suggestion, it was a good one indeed, I will send the
update shortly

--
~Vinod