2020-06-28 04:39:17

by B K Karthik

[permalink] [raw]
Subject: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

Fixed a coding style issue.

Signed-off-by: B K Karthik <[email protected]>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
index 90d125ba080f..c90730513438 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
@@ -495,11 +495,11 @@ static int ov2680_h_flip(struct v4l2_subdev *sd, s32 value)
ret = ov2680_read_reg(client, 1, OV2680_MIRROR_REG, &val);
if (ret)
return ret;
- if (value) {
+ if (value)
val |= OV2680_FLIP_MIRROR_BIT_ENABLE;
- } else {
+ else
val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE;
- }
+
ret = ov2680_write_reg(client, 1,
OV2680_MIRROR_REG, val);
if (ret)
--
2.20.1


Attachments:
(No filename) (895.00 B)
signature.asc (673.00 B)
Download all attachments

2020-06-29 19:11:23

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Jun 29, 2020 at 10:43:36AM -0400, B K Karthik wrote:
> Did this get burried in along with a bunch of other patches? I am sending this email only because I did not recieve a negetive acknowledgement on the patch.
>
> I apologize if this message was hurtful / disrespectfull in any manner,
> thank you for reading this message.
>
> karthik
>
> On 20/06/28 12:38AM, B K Karthik wrote:

You sent this one day ago.

Please be patient, some maintainers only get to patches every few weeks.
If, after 2 weeks, there has not been a response, then resend it.

Remember, maintainers have other work to do as well, and staging patches
are usually down the list of things they work on.

(hint, I'm not the maintainer of this part of the staging tree...)

thanks,

greg k-h

2020-06-29 19:36:03

by B K Karthik

[permalink] [raw]
Subject: Re: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

Did this get burried in along with a bunch of other patches? I am sending this email only because I did not recieve a negetive acknowledgement on the patch.

I apologize if this message was hurtful / disrespectfull in any manner,
thank you for reading this message.

karthik

On 20/06/28 12:38AM, B K Karthik wrote:
> Fixed a coding style issue.
>
> Signed-off-by: B K Karthik <[email protected]>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> index 90d125ba080f..c90730513438 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> @@ -495,11 +495,11 @@ static int ov2680_h_flip(struct v4l2_subdev *sd, s32 value)
> ret = ov2680_read_reg(client, 1, OV2680_MIRROR_REG, &val);
> if (ret)
> return ret;
> - if (value) {
> + if (value)
> val |= OV2680_FLIP_MIRROR_BIT_ENABLE;
> - } else {
> + else
> val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE;
> - }
> +
> ret = ov2680_write_reg(client, 1,
> OV2680_MIRROR_REG, val);
> if (ret)
> --
> 2.20.1



Attachments:
(No filename) (1.25 kB)
signature.asc (673.00 B)
Download all attachments