2020-06-29 19:34:24

by Krzysztof Kozlowski

Subject: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

Add @0 unit address to 'soc' node match its 'reg' property and silence
DTC warning:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Not tested on HW.
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 6721966140f4..ebe089469b5f 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -256,7 +256,7 @@
cpu_on = <0xC4000003>;
};

- soc: soc {
+ soc: soc@0 {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
--
2.17.1

2020-06-30 10:12:18

by Marek Szyprowski

Subject: Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

On 29.06.2020 21:33, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and silence
> DTC warning:
>
> Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Tested-by: Marek Szyprowski <[email protected]>
> ---
>
> Not tested on HW.
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 6721966140f4..ebe089469b5f 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -256,7 +256,7 @@
> cpu_on = <0xC4000003>;
> };
>
> - soc: soc {
> + soc: soc@0 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland

2020-07-07 06:46:32

by Krzysztof Kozlowski

Subject: Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

On Mon, Jun 29, 2020 at 09:33:37PM +0200, Krzysztof Kozlowski wrote:
> Add @0 unit address to 'soc' node match its 'reg' property and silence
> DTC warning:
>
> Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Not tested on HW.
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-

Applied.

Best regards,
Krzysztof