This serie adds SMBus Alert and SMBus Host-Notify features for the i2c-stm32f7.
This serie v2 rework comments from the 1st serie and replace the very generic
reg_client / unreg_client callback with HOST_NOTIFY only reg_hnotify_cli
and unreg_hnotify_cli callbacks.
Alain Volmat (4):
i2c: smbus: add core function handling SMBus host-notify
i2c: addition of client hnotify reg/unreg callbacks
dt-bindings: i2c-stm32: add SMBus Alert bindings
i2c: stm32f7: Add SMBus-specific protocols support
.../devicetree/bindings/i2c/st,stm32-i2c.yaml | 4 +
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-stm32f7.c | 194 +++++++++++++++++++--
drivers/i2c/i2c-core-base.c | 18 +-
drivers/i2c/i2c-core-smbus.c | 110 ++++++++++++
include/linux/i2c-smbus.h | 2 +
include/linux/i2c.h | 8 +
7 files changed, 325 insertions(+), 12 deletions(-)
On Thu, Jun 25, 2020 at 09:39:25AM +0200, Alain Volmat wrote:
> This serie adds SMBus Alert and SMBus Host-Notify features for the i2c-stm32f7.
If it is not too much work for you, I think it makes sense to split the
series into two, i.e. HostNotify and SMBusAlert parts.
On Tue, Jun 30, 2020 at 06:05:00PM +0200, Wolfram Sang wrote:
> On Thu, Jun 25, 2020 at 09:39:25AM +0200, Alain Volmat wrote:
> > This serie adds SMBus Alert and SMBus Host-Notify features for the i2c-stm32f7.
>
> If it is not too much work for you, I think it makes sense to split the
> series into two, i.e. HostNotify and SMBusAlert parts.
>
I've just prepared the 1st new serie with only the HostNotify bits in it.
(basically, the core part, the dt-bindings with the enable-host-notify, and
the usage within i2c-stm32f7).
You mentioned in the other thread that you still have some more review comment
I believe. Is that right ? If that is so, I'll wait for those comment and
then push that new serie for review.
> I've just prepared the 1st new serie with only the HostNotify bits in it.
> (basically, the core part, the dt-bindings with the enable-host-notify, and
> the usage within i2c-stm32f7).
Cool, thanks!
> You mentioned in the other thread that you still have some more review comment
> I believe. Is that right ? If that is so, I'll wait for those comment and
> then push that new serie for review.
Yes, for the core part. Please wait for these comments.