2020-07-02 04:49:44

by B K Karthik

[permalink] [raw]
Subject: [PATCH] staging: rtl8188eu: include: rtl8188e_xmit.h: fixed multiple blank space coding style issues

added blank spaces to improve code readability.

Signed-off-by: B K Karthik <[email protected]>
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
index 49884cceb349..c115007d883d 100644
--- a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
+++ b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
@@ -30,11 +30,11 @@
#define SET_EARLYMODE_LEN2_1(__pAddr, __Value) \
SET_BITS_TO_LE_4BYTE(__pAddr, 28, 4, __Value)
#define SET_EARLYMODE_LEN2_2(__pAddr, __Value) \
- SET_BITS_TO_LE_4BYTE(__pAddr+4, 0, 8, __Value)
+ SET_BITS_TO_LE_4BYTE(__pAdd r +4, 0, 8, __Value)
#define SET_EARLYMODE_LEN3(__pAddr, __Value) \
- SET_BITS_TO_LE_4BYTE(__pAddr+4, 8, 12, __Value)
+ SET_BITS_TO_LE_4BYTE(__pAddr + 4, 8, 12, __Value)
#define SET_EARLYMODE_LEN4(__pAddr, __Value) \
- SET_BITS_TO_LE_4BYTE(__pAddr+4, 20, 12, __Value)
+ SET_BITS_TO_LE_4BYTE(__pAddr + 4, 20, 12, __Value)

/* */
/* defined for TX DESC Operation */
@@ -100,7 +100,7 @@ enum TXDESC_SC {

#define txdesc_set_ccx_sw_88e(txdesc, value) \
do { \
- ((struct txdesc_88e *)(txdesc))->sw1 = (((value)>>8) & 0x0f); \
+ ((struct txdesc_88e *)(txdesc))->sw1 = (((value) >> 8) & 0x0f); \
((struct txdesc_88e *)(txdesc))->sw0 = ((value) & 0xff); \
} while (0)

@@ -138,9 +138,9 @@ struct txrpt_ccx_88e {
u8 sw0;
};

-#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1<<8))
+#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1 << 8))
#define txrpt_ccx_qtime_88e(txrpt_ccx) \
- ((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1<<8))
+ ((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1 << 8))

void rtl8188e_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc,
u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull);
--
2.20.1


Attachments:
(No filename) (1.94 kB)
signature.asc (673.00 B)
Download all attachments

2020-07-02 04:55:56

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8188eu: include: rtl8188e_xmit.h: fixed multiple blank space coding style issues

On Thu, Jul 02, 2020 at 12:48:42AM -0400, B K Karthik wrote:
> added blank spaces to improve code readability.
>
> Signed-off-by: B K Karthik <[email protected]>
> ---
> drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
> index 49884cceb349..c115007d883d 100644
> --- a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
> @@ -30,11 +30,11 @@
> #define SET_EARLYMODE_LEN2_1(__pAddr, __Value) \
> SET_BITS_TO_LE_4BYTE(__pAddr, 28, 4, __Value)
> #define SET_EARLYMODE_LEN2_2(__pAddr, __Value) \
> - SET_BITS_TO_LE_4BYTE(__pAddr+4, 0, 8, __Value)
> + SET_BITS_TO_LE_4BYTE(__pAdd r +4, 0, 8, __Value)
^

did this get compile tested? :)

-Kees

> #define SET_EARLYMODE_LEN3(__pAddr, __Value) \
> - SET_BITS_TO_LE_4BYTE(__pAddr+4, 8, 12, __Value)
> + SET_BITS_TO_LE_4BYTE(__pAddr + 4, 8, 12, __Value)
> #define SET_EARLYMODE_LEN4(__pAddr, __Value) \
> - SET_BITS_TO_LE_4BYTE(__pAddr+4, 20, 12, __Value)
> + SET_BITS_TO_LE_4BYTE(__pAddr + 4, 20, 12, __Value)
>
> /* */
> /* defined for TX DESC Operation */
> @@ -100,7 +100,7 @@ enum TXDESC_SC {
>
> #define txdesc_set_ccx_sw_88e(txdesc, value) \
> do { \
> - ((struct txdesc_88e *)(txdesc))->sw1 = (((value)>>8) & 0x0f); \
> + ((struct txdesc_88e *)(txdesc))->sw1 = (((value) >> 8) & 0x0f); \
> ((struct txdesc_88e *)(txdesc))->sw0 = ((value) & 0xff); \
> } while (0)
>
> @@ -138,9 +138,9 @@ struct txrpt_ccx_88e {
> u8 sw0;
> };
>
> -#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1<<8))
> +#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1 << 8))
> #define txrpt_ccx_qtime_88e(txrpt_ccx) \
> - ((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1<<8))
> + ((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1 << 8))
>
> void rtl8188e_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc,
> u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull);
> --
> 2.20.1
>



--
Kees Cook