2020-07-03 09:56:25

by Benjamin GAIGNARD

[permalink] [raw]
Subject: [PATCH 0/5] ARM: STM32: Add compatibles for syscon nodes

Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a more specific compatible")
it is required to provide at least 2 compatibles string for syscon node.
This series update the syscon of the STM32 SoCs to fix the reported errors.

Benjamin Gaignard (5):
dt-bingings: arm: stm32: Add compatibles for syscon nodes
ARM: dts: stm32: Add compatibles for syscon for stm32f426
ARM: dts: stm32: Add compatibles for syscon for stm32f746
ARM: dts: stm32: Add compatibles for syscon for stm32h743
ARM: dts: stm32: Add compatibles for syscon for stm32mp151

.../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 14 +++++++++++++-
arch/arm/boot/dts/stm32f429.dtsi | 6 +++---
arch/arm/boot/dts/stm32f746.dtsi | 6 +++---
arch/arm/boot/dts/stm32h743.dtsi | 6 +++---
arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
5 files changed, 23 insertions(+), 11 deletions(-)

--
2.15.0


2020-07-03 09:57:43

by Benjamin GAIGNARD

[permalink] [raw]
Subject: [PATCH 2/5] ARM: dts: stm32: Add compatibles for syscon for stm32f426

Syscon nodes needs at least 2 compatibles to be compliant why yaml documentation.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f429.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 393f43c85a3c..f3a8d43993c9 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -586,8 +586,8 @@
status = "disabled";
};

- syscfg: system-config@40013800 {
- compatible = "syscon";
+ syscfg: syscon@40013800 {
+ compatible = "st,stm32-syscfg", "syscon";
reg = <0x40013800 0x400>;
};

@@ -674,7 +674,7 @@
};

pwrcfg: power-config@40007000 {
- compatible = "syscon";
+ compatible = "st,stm32-power-config", "syscon";
reg = <0x40007000 0x400>;
};

--
2.15.0

2020-07-03 09:59:25

by Benjamin GAIGNARD

[permalink] [raw]
Subject: [PATCH 1/5] dt-bingings: arm: stm32: Add compatibles for syscon nodes

Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a more specific compatible")
it is required to provide at least 2 compatibles string for syscon node.
This patch document the missing compatibles for stm32 SoCs.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
.../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
index cf5db5e273f3..6f1cd0103c74 100644
--- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
@@ -16,6 +16,9 @@ properties:
- items:
- enum:
- st,stm32mp157-syscfg
+ - st,stm32mp151-pwr-mcu
+ - st,stm32-syscfg
+ - st,stm32-power-config
- const: syscon

reg:
@@ -27,7 +30,16 @@ properties:
required:
- compatible
- reg
- - clocks
+
+if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - st,stm32mp157-syscfg
+then:
+ required:
+ - clocks

additionalProperties: false

--
2.15.0

2020-07-03 09:59:31

by Benjamin GAIGNARD

[permalink] [raw]
Subject: [PATCH 5/5] ARM: dts: stm32: Add compatibles for syscon for stm32mp151

Syscon nodes needs at least 2 compatibles to be compliant why yaml documentation.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index 36f38a95b4de..0b86a916e297 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1127,7 +1127,7 @@
};

pwr_mcu: pwr_mcu@50001014 {
- compatible = "syscon";
+ compatible = "st,stm32mp151-pwr-mcu", "syscon";
reg = <0x50001014 0x4>;
};

--
2.15.0

2020-07-15 21:05:57

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 1/5] dt-bingings: arm: stm32: Add compatibles for syscon nodes

On Fri, 03 Jul 2020 11:55:16 +0200, Benjamin Gaignard wrote:
> Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a more specific compatible")
> it is required to provide at least 2 compatibles string for syscon node.
> This patch document the missing compatibles for stm32 SoCs.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>

Typo in the subject, otherwise:

Reviewed-by: Rob Herring <[email protected]>

2020-07-21 08:44:16

by Alexandre Torgue

[permalink] [raw]
Subject: Re: [PATCH 0/5] ARM: STM32: Add compatibles for syscon nodes

Hi Benjamin

On 7/3/20 11:55 AM, Benjamin Gaignard wrote:
> Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a more specific compatible")
> it is required to provide at least 2 compatibles string for syscon node.
> This series update the syscon of the STM32 SoCs to fix the reported errors.
>
> Benjamin Gaignard (5):
> dt-bingings: arm: stm32: Add compatibles for syscon nodes
> ARM: dts: stm32: Add compatibles for syscon for stm32f426
> ARM: dts: stm32: Add compatibles for syscon for stm32f746
> ARM: dts: stm32: Add compatibles for syscon for stm32h743
> ARM: dts: stm32: Add compatibles for syscon for stm32mp151
>
> .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 14 +++++++++++++-
> arch/arm/boot/dts/stm32f429.dtsi | 6 +++---
> arch/arm/boot/dts/stm32f746.dtsi | 6 +++---
> arch/arm/boot/dts/stm32h743.dtsi | 6 +++---
> arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
> 5 files changed, 23 insertions(+), 11 deletions(-)
>

Series applied on stm32-next by fixing subject of patch [1].

Regards
Alex