2020-07-03 11:48:05

by Ondřej Jirman

Subject: [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example

This patchset fixes warnings in the example in display/bridge/nwl-dsi.yaml
revealed during port of display/panel/rocktech,jh057n00900.yaml to
yaml.

Please take a look.

thank you and regards,
Ondrej Jirman

Ondrej Jirman (2):
dt-bindings: display: Fix example in nwl-dsi.yaml
dt-binding: display: Allow a single port node on rocktech,jh057n00900

.../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
.../bindings/display/panel/rocktech,jh057n00900.yaml | 1 +
2 files changed, 6 insertions(+), 4 deletions(-)

--
2.27.0

2020-07-03 11:48:23

by Ondřej Jirman

Subject: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900

The display has one port. Allow it in the binding.

Signed-off-by: Ondrej Jirman <[email protected]>
---
.../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index a6985cd947fb..d5733ef30954 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -24,6 +24,7 @@ properties:
# Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
- xingbangda,xbd599

+ port: true
reg:
maxItems: 1
description: DSI virtual channel
--
2.27.0

2020-07-03 11:50:34

by Ondřej Jirman

Subject: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml

The example is now validated against rocktech,jh057n00900 schema
that was ported to yaml, and didn't validate with:

- '#address-cells', '#size-cells', 'port@0' do not match any of
the regexes: 'pinctrl-[0-9]+'
- 'vcc-supply' is a required property
- 'iovcc-supply' is a required property
- 'reset-gpios' is a required property

Fix it.

Signed-off-by: Ondrej Jirman <[email protected]>
---
.../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
index 8aff2d68fc33..2c4c34e3bc29 100644
--- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
@@ -165,6 +165,7 @@ examples:
- |

#include <dt-bindings/clock/imx8mq-clock.h>
+ #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/reset/imx8mq-reset.h>

@@ -191,12 +192,12 @@ examples:
phy-names = "dphy";

panel@0 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "rocktech,jh057n00900";
reg = <0>;
- port@0 {
- reg = <0>;
+ vcc-supply = <&reg_2v8_p>;
+ iovcc-supply = <&reg_1v8_p>;
+ reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+ port {
panel_in: endpoint {
remote-endpoint = <&mipi_dsi_out>;
};
--
2.27.0

2020-07-15 21:09:08

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml

On Fri, 03 Jul 2020 13:47:16 +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
>
> - '#address-cells', '#size-cells', 'port@0' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
>
> Fix it.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2020-07-15 21:11:32

by Rob Herring

Subject: Re: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900

On Fri, 03 Jul 2020 13:47:17 +0200, Ondrej Jirman wrote:
> The display has one port. Allow it in the binding.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Rob Herring <[email protected]>

2020-07-18 16:55:50

by Guido Günther

Subject: Re: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900

Hi,
On Fri, Jul 03, 2020 at 01:47:17PM +0200, Ondrej Jirman wrote:
> The display has one port. Allow it in the binding.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> index a6985cd947fb..d5733ef30954 100644
> --- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> @@ -24,6 +24,7 @@ properties:
> # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
> - xingbangda,xbd599
>
> + port: true
> reg:
> maxItems: 1
> description: DSI virtual channel

Reviewed-by: Guido G?nther <[email protected]>
-- Guido

> --
> 2.27.0
>

2020-07-18 16:57:31

by Guido Günther

Subject: Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml

Hi,
On Fri, Jul 03, 2020 at 01:47:16PM +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
>
> - '#address-cells', '#size-cells', 'port@0' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
>
> Fix it.
>
> Signed-off-by: Ondrej Jirman <[email protected]>
> ---
> .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> index 8aff2d68fc33..2c4c34e3bc29 100644
> --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> @@ -165,6 +165,7 @@ examples:
> - |
>
> #include <dt-bindings/clock/imx8mq-clock.h>
> + #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/imx8mq-reset.h>
>
> @@ -191,12 +192,12 @@ examples:
> phy-names = "dphy";
>
> panel@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> compatible = "rocktech,jh057n00900";
> reg = <0>;
> - port@0 {
> - reg = <0>;
> + vcc-supply = <&reg_2v8_p>;
> + iovcc-supply = <&reg_1v8_p>;
> + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> + port {
> panel_in: endpoint {
> remote-endpoint = <&mipi_dsi_out>;
> };

Reviewed-by: Guido G?nther <[email protected]>
-- Guido

2020-07-21 15:36:33

by Rob Herring

Subject: Re: [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example

On Fri, Jul 3, 2020 at 5:47 AM Ondrej Jirman <[email protected]> wrote:
>
> This patchset fixes warnings in the example in display/bridge/nwl-dsi.yaml
> revealed during port of display/panel/rocktech,jh057n00900.yaml to
> yaml.
>
> Please take a look.
>
> thank you and regards,
> Ondrej Jirman
>
> Ondrej Jirman (2):
> dt-bindings: display: Fix example in nwl-dsi.yaml
> dt-binding: display: Allow a single port node on rocktech,jh057n00900

Series applied to drm-misc.

Rob