2020-07-05 07:56:21

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.

If there are any URLs to be removed completely or at least not HTTPSified:
Just clearly say so and I'll *undo my change*.
See also https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See https://lkml.org/lkml/2020/6/26/837

Documentation/devicetree/bindings/media/xilinx/video.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/xilinx/video.txt b/Documentation/devicetree/bindings/media/xilinx/video.txt
index 68ac210e688e..d0335ca0cd57 100644
--- a/Documentation/devicetree/bindings/media/xilinx/video.txt
+++ b/Documentation/devicetree/bindings/media/xilinx/video.txt
@@ -32,4 +32,4 @@ The following properties are common to all Xilinx video IP cores.
defaults to "mono".


-[UG934] http://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
+[UG934] https://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
--
2.27.0


2020-07-08 10:50:13

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores



On 05. 07. 20 9:55, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See https://lkml.org/lkml/2020/6/26/837
>
> Documentation/devicetree/bindings/media/xilinx/video.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/xilinx/video.txt b/Documentation/devicetree/bindings/media/xilinx/video.txt
> index 68ac210e688e..d0335ca0cd57 100644
> --- a/Documentation/devicetree/bindings/media/xilinx/video.txt
> +++ b/Documentation/devicetree/bindings/media/xilinx/video.txt
> @@ -32,4 +32,4 @@ The following properties are common to all Xilinx video IP cores.
> defaults to "mono".
>
>
> -[UG934] http://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
> +[UG934] https://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
>

I have no problem with this change.

Acked-by: Michal Simek <[email protected]>

Thanks,
Michal

2020-07-15 00:17:32

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores

Hi Alexander,

Thank you for the patch.

The subject line should be

dt-bindings: media: xilinx: Replace HTTP links with HTTPS ones

On Sun, Jul 05, 2020 at 09:55:24AM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

Will you get this patch merged as part of a bigger series, or do you
expect us to take care of it ? In the latter case, if you agree with the
subject line change, there's no need to resubmit, I can fix this when
applying the patch.

> ---
> Continuing my work started at 93431e0607e5.
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See https://lkml.org/lkml/2020/6/26/837
>
> Documentation/devicetree/bindings/media/xilinx/video.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/xilinx/video.txt b/Documentation/devicetree/bindings/media/xilinx/video.txt
> index 68ac210e688e..d0335ca0cd57 100644
> --- a/Documentation/devicetree/bindings/media/xilinx/video.txt
> +++ b/Documentation/devicetree/bindings/media/xilinx/video.txt
> @@ -32,4 +32,4 @@ The following properties are common to all Xilinx video IP cores.
> defaults to "mono".
>
>
> -[UG934] http://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
> +[UG934] https://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf

--
Regards,

Laurent Pinchart

2020-07-15 06:35:44

by Alexander A. Klimov

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores



Am 15.07.20 um 01:57 schrieb Laurent Pinchart:
> Hi Alexander,
>
> Thank you for the patch.
>
> The subject line should be
>
> dt-bindings: media: xilinx: Replace HTTP links with HTTPS ones
>
> On Sun, Jul 05, 2020 at 09:55:24AM +0200, Alexander A. Klimov wrote:
>> Rationale:
>> Reduces attack surface on kernel devs opening the links for MITM
>> as HTTPS traffic is much harder to manipulate.
>>
>> Deterministic algorithm:
>> For each file:
>> If not .svg:
>> For each line:
>> If doesn't contain `\bxmlns\b`:
>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>> If both the HTTP and HTTPS versions
>> return 200 OK and serve the same content:
>> Replace HTTP with HTTPS.
>>
>> Signed-off-by: Alexander A. Klimov <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>
> Will you get this patch merged as part of a bigger series, or do you
> expect us to take care of it ? In the latter case, if you agree with the
I've just followed the patch submission instructions as for any
non-treewide patch. So yes, I assume the people I write to take care of
the patch.

> subject line change, there's no need to resubmit, I can fix this when
> applying the patch.
OK.

>
>> ---
>> Continuing my work started at 93431e0607e5.
>>
>> If there are any URLs to be removed completely or at least not HTTPSified:
>> Just clearly say so and I'll *undo my change*.
>> See also https://lkml.org/lkml/2020/6/27/64
>>
>> If there are any valid, but yet not changed URLs:
>> See https://lkml.org/lkml/2020/6/26/837
>>
>> Documentation/devicetree/bindings/media/xilinx/video.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/xilinx/video.txt b/Documentation/devicetree/bindings/media/xilinx/video.txt
>> index 68ac210e688e..d0335ca0cd57 100644
>> --- a/Documentation/devicetree/bindings/media/xilinx/video.txt
>> +++ b/Documentation/devicetree/bindings/media/xilinx/video.txt
>> @@ -32,4 +32,4 @@ The following properties are common to all Xilinx video IP cores.
>> defaults to "mono".
>>
>>
>> -[UG934] http://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
>> +[UG934] https://www.xilinx.com/support/documentation/ip_documentation/axi_videoip/v1_0/ug934_axi_videoIP.pdf
>

2020-07-15 21:47:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: Xilinx video IP cores

On Sun, 05 Jul 2020 09:55:24 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
>
> If there are any URLs to be removed completely or at least not HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See https://lkml.org/lkml/2020/6/26/837
>
> Documentation/devicetree/bindings/media/xilinx/video.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!